From 00130cff99f88e13fec87378bdf476cfea6aa147 Mon Sep 17 00:00:00 2001 From: Eljay Date: Sun, 21 Jun 2015 16:02:05 +0100 Subject: [PATCH] Fix `missing_docs` lint for const and static. --- src/librustc_lint/builtin.rs | 2 ++ src/test/compile-fail/lint-missing-doc.rs | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs index a4681acdd755..53b1abe2d314 100644 --- a/src/librustc_lint/builtin.rs +++ b/src/librustc_lint/builtin.rs @@ -1612,6 +1612,8 @@ impl LintPass for MissingDoc { } return }, + ast::ItemConst(..) => "a constant", + ast::ItemStatic(..) => "a static", _ => return }; diff --git a/src/test/compile-fail/lint-missing-doc.rs b/src/test/compile-fail/lint-missing-doc.rs index 04db6c8c8f39..550183588610 100644 --- a/src/test/compile-fail/lint-missing-doc.rs +++ b/src/test/compile-fail/lint-missing-doc.rs @@ -149,6 +149,27 @@ pub enum PubBaz3 { #[doc(hidden)] pub fn baz() {} + +const FOO: u32 = 0; +/// dox +pub const FOO1: u32 = 0; +#[allow(missing_docs)] +pub const FOO2: u32 = 0; +#[doc(hidden)] +pub const FOO3: u32 = 0; +pub const FOO4: u32 = 0; //~ ERROR: missing documentation for a const + + +static BAR: u32 = 0; +/// dox +pub static BAR1: u32 = 0; +#[allow(missing_docs)] +pub static BAR2: u32 = 0; +#[doc(hidden)] +pub static BAR3: u32 = 0; +pub static BAR4: u32 = 0; //~ ERROR: missing documentation for a static + + mod internal_impl { /// dox pub fn documented() {}