From 02782bba604e3edc5d356dd3e153667cf1474949 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Mon, 29 Nov 2021 10:24:51 +0100 Subject: [PATCH] Return ConstStability instead of &ConstStability in Item::const_stability --- src/librustdoc/clean/types.rs | 4 ++-- src/librustdoc/html/format.rs | 5 +---- src/librustdoc/html/render/mod.rs | 4 ++-- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/librustdoc/clean/types.rs b/src/librustdoc/clean/types.rs index aac7dbaca2b8..5aaaa99dadb4 100644 --- a/src/librustdoc/clean/types.rs +++ b/src/librustdoc/clean/types.rs @@ -376,8 +376,8 @@ impl Item { self.def_id.as_def_id().and_then(|did| tcx.lookup_stability(did)) } - crate fn const_stability<'tcx>(&self, tcx: TyCtxt<'tcx>) -> Option<&'tcx ConstStability> { - self.def_id.as_def_id().and_then(|did| tcx.lookup_const_stability(did)) + crate fn const_stability<'tcx>(&self, tcx: TyCtxt<'tcx>) -> Option { + self.def_id.as_def_id().and_then(|did| tcx.lookup_const_stability(did)).map(|cs| *cs) } crate fn deprecation(&self, tcx: TyCtxt<'_>) -> Option { diff --git a/src/librustdoc/html/format.rs b/src/librustdoc/html/format.rs index 34742fac0e4b..fdb52703edf7 100644 --- a/src/librustdoc/html/format.rs +++ b/src/librustdoc/html/format.rs @@ -1349,10 +1349,7 @@ impl PrintWithSpace for hir::Mutability { } } -crate fn print_constness_with_space( - c: &hir::Constness, - s: Option<&ConstStability>, -) -> &'static str { +crate fn print_constness_with_space(c: &hir::Constness, s: Option) -> &'static str { match (c, s) { // const stable or when feature(staged_api) is not set ( diff --git a/src/librustdoc/html/render/mod.rs b/src/librustdoc/html/render/mod.rs index eaeda4d178bb..a1db66a4d52d 100644 --- a/src/librustdoc/html/render/mod.rs +++ b/src/librustdoc/html/render/mod.rs @@ -805,7 +805,7 @@ fn assoc_type( fn render_stability_since_raw( w: &mut Buffer, ver: Option, - const_stability: Option<&ConstStability>, + const_stability: Option, containing_ver: Option, containing_const_ver: Option, ) { @@ -814,7 +814,7 @@ fn render_stability_since_raw( match (ver, const_stability) { // stable and const stable (Some(v), Some(ConstStability { level: StabilityLevel::Stable { since }, .. })) - if Some(*since) != containing_const_ver => + if Some(since) != containing_const_ver => { write!( w,