user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Cleanup

Browse source
This commit is contained in:
mcarton 2016-02-27 18:14:37 +01:00
parent 3a5b9a707c
commit 05178c92b9
1 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/formatting.rs
View file

@ -88,8 +88,9 @@ fn check_assign(cx: &EarlyContext, expr: &ast::Expr) {
if !differing_macro_contexts(lhs.span, rhs.span) && !in_macro(cx, lhs.span) {
let eq_span = mk_sp(lhs.span.hi, rhs.span.lo);
if let Some((sub_rhs, op)) = check_unop(rhs) {
if let ast::ExprKind::Unary(op, ref sub_rhs) = rhs.node {
if let Some(eq_snippet) = snippet_opt(cx, eq_span) {
let op = ast::UnOp::to_string(op);
let eqop_span = mk_sp(lhs.span.hi, sub_rhs.span.lo);
if eq_snippet.ends_with('=') {
span_note_and_lint(cx,
@ -105,13 +106,6 @@ fn check_assign(cx: &EarlyContext, expr: &ast::Expr) {
}
}
fn check_unop(expr: &ast::Expr) -> Option<(&P<ast::Expr>, &'static str)> {
match expr.node {
ast::ExprKind::Unary(op, ref expr) => Some((expr, ast::UnOp::to_string(op))),
_ => None,
}
}
/// Implementation of the SUSPICIOUS_ELSE_FORMATTING lint for weird `else if`.
fn check_else_if(cx: &EarlyContext, expr: &ast::Expr) {
if let Some((then, &Some(ref else_))) = unsugar_if(expr) {