user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Changed documentation example and removed comments

Browse source
This commit is contained in:
Red Rapious 2023-08-21 19:21:02 +02:00
parent e33a17e33c
commit 073149a7ef
1 changed files with 3 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

40
clippy_lints/src/reserve_after_initialization.rs
View file

@ -24,15 +24,12 @@ declare_clippy_lint! {
///
/// ### Example
/// ```rust
/// {
/// let mut v = vec![];
/// v.reserve(space_hint);
/// v
/// }
/// let mut v: Vec<usize> = vec![];
/// v.reserve(10);
/// ```
/// Use instead:
/// ```rust
/// Vec::with_capacity(space_hint)
/// let mut v: Vec<usize> = Vec::with_capacity(10);
/// ```
#[clippy::version = "1.73.0"]
pub RESERVE_AFTER_INITIALIZATION,
@ -41,37 +38,6 @@ declare_clippy_lint! {
}
impl_lint_pass!(ReserveAfterInitialization => [RESERVE_AFTER_INITIALIZATION]);
/*impl<'tcx> LateLintPass<'tcx> for ReserveAfterInitialization {
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx rustc_hir::Expr<'_>) {
if let ExprKind::Assign(left, right, _) = expr.kind
&& let ExprKind::Path(QPath::Resolved(None, path)) = left.kind
&& let [name] = &path.segments
&& let Res::Local(id) = path.res
&& let Some(init) = get_vec_init_kind(cx, right)
&& !matches!(init, VecInitKind::WithExprCapacity(_)) {
span_lint_and_help(
cx,
RESERVE_AFTER_INITIALIZATION,
expr.span,
"`reserve` called just after the initialisation of the vector",
None,
"use `Vec::with_capacity(space_hint)` instead"
);
}
}
/*fn check_block(&mut self, cx: &LateContext<'_>, block: &'_ rustc_hir::Block<'_>) {
span_lint_and_help(
cx,
RESERVE_AFTER_INITIALIZATION,
block.span,
"`reserve` called just after the initialisation of the vector",
None,
"use `Vec::with_capacity(space_hint)` instead"
);
}*/
}*/
#[derive(Default)]
pub struct ReserveAfterInitialization {
searcher: Option<VecReserveSearcher>,