librustc: Make Copy opt-in.
This change makes the compiler no longer infer whether types (structures
and enumerations) implement the `Copy` trait (and thus are implicitly
copyable). Rather, you must implement `Copy` yourself via `impl Copy for
MyType {}`.
A new warning has been added, `missing_copy_implementations`, to warn
you if a non-generic public type has been added that could have
implemented `Copy` but didn't.
For convenience, you may *temporarily* opt out of this behavior by using
`#![feature(opt_out_copy)]`. Note though that this feature gate will never be
accepted and will be removed by the time that 1.0 is released, so you should
transition your code away from using it.
This breaks code like:
#[deriving(Show)]
struct Point2D {
x: int,
y: int,
}
fn main() {
let mypoint = Point2D {
x: 1,
y: 1,
};
let otherpoint = mypoint;
println!("{}{}", mypoint, otherpoint);
}
Change this code to:
#[deriving(Show)]
struct Point2D {
x: int,
y: int,
}
impl Copy for Point2D {}
fn main() {
let mypoint = Point2D {
x: 1,
y: 1,
};
let otherpoint = mypoint;
println!("{}{}", mypoint, otherpoint);
}
This is the backwards-incompatible part of #13231.
Part of RFC #3.
[breaking-change]
This commit is contained in:
parent
c7a9b49d1b
commit
096a28607f
277 changed files with 2182 additions and 513 deletions
|
|
@ -1178,6 +1178,8 @@ pub enum PrimitiveType {
|
|||
PrimitiveTuple,
|
||||
}
|
||||
|
||||
impl Copy for PrimitiveType {}
|
||||
|
||||
#[deriving(Clone, Encodable, Decodable)]
|
||||
pub enum TypeKind {
|
||||
TypeEnum,
|
||||
|
|
@ -1190,6 +1192,8 @@ pub enum TypeKind {
|
|||
TypeTypedef,
|
||||
}
|
||||
|
||||
impl Copy for TypeKind {}
|
||||
|
||||
impl PrimitiveType {
|
||||
fn from_str(s: &str) -> Option<PrimitiveType> {
|
||||
match s.as_slice() {
|
||||
|
|
@ -1843,6 +1847,8 @@ pub enum Mutability {
|
|||
Immutable,
|
||||
}
|
||||
|
||||
impl Copy for Mutability {}
|
||||
|
||||
impl Clean<Mutability> for ast::Mutability {
|
||||
fn clean(&self, _: &DocContext) -> Mutability {
|
||||
match self {
|
||||
|
|
|
|||
|
|
@ -82,6 +82,8 @@ pub enum StructType {
|
|||
Unit
|
||||
}
|
||||
|
||||
impl Copy for StructType {}
|
||||
|
||||
pub enum TypeBound {
|
||||
RegionBound,
|
||||
TraitBound(ast::TraitRef)
|
||||
|
|
|
|||
|
|
@ -48,6 +48,11 @@ pub struct WhereClause<'a>(pub &'a clean::Generics);
|
|||
/// Wrapper struct for emitting type parameter bounds.
|
||||
pub struct TyParamBounds<'a>(pub &'a [clean::TyParamBound]);
|
||||
|
||||
impl Copy for VisSpace {}
|
||||
impl Copy for FnStyleSpace {}
|
||||
impl Copy for MutableSpace {}
|
||||
impl Copy for RawMutableSpace {}
|
||||
|
||||
impl VisSpace {
|
||||
pub fn get(&self) -> Option<ast::Visibility> {
|
||||
let VisSpace(v) = *self; v
|
||||
|
|
|
|||
|
|
@ -41,6 +41,8 @@ pub enum ItemType {
|
|||
Constant = 18,
|
||||
}
|
||||
|
||||
impl Copy for ItemType {}
|
||||
|
||||
impl ItemType {
|
||||
pub fn from_item(item: &clean::Item) -> ItemType {
|
||||
match item.inner {
|
||||
|
|
|
|||
|
|
@ -225,7 +225,13 @@ struct Source<'a>(&'a str);
|
|||
// Helper structs for rendering items/sidebars and carrying along contextual
|
||||
// information
|
||||
|
||||
struct Item<'a> { cx: &'a Context, item: &'a clean::Item, }
|
||||
struct Item<'a> {
|
||||
cx: &'a Context,
|
||||
item: &'a clean::Item,
|
||||
}
|
||||
|
||||
impl<'a> Copy for Item<'a> {}
|
||||
|
||||
struct Sidebar<'a> { cx: &'a Context, item: &'a clean::Item, }
|
||||
|
||||
/// Struct representing one entry in the JS search index. These are all emitted
|
||||
|
|
|
|||
|
|
@ -39,6 +39,8 @@ pub struct Counts {
|
|||
pub unmarked: uint,
|
||||
}
|
||||
|
||||
impl Copy for Counts {}
|
||||
|
||||
impl Add<Counts, Counts> for Counts {
|
||||
fn add(&self, other: &Counts) -> Counts {
|
||||
Counts {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue