user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove brackets around type name when it is no longer a prefix

Browse source 
When `<T>::default()` is replaced by `T` when `T` is a singleton,
the brackets around the type name can be removed.
This commit is contained in:
Samuel Tardieu 2025-03-06 23:08:15 +01:00
parent 253ecb9d7d
commit 0aa0d074cd
4 changed files with 37 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
clippy_lints/src/default_constructed_unit_structs.rs
View file

@ -1,6 +1,6 @@
use clippy_utils::diagnostics::span_lint_and_then;
use clippy_utils::is_ty_alias;
use clippy_utils::sugg::DiagExt as _;
use clippy_utils::source::SpanRangeExt as _;
use hir::ExprKind;
use hir::def::Res;
use rustc_errors::Applicability;
@ -74,16 +74,20 @@ impl LateLintPass<'_> for DefaultConstructedUnitStructs {
// do not suggest replacing an expression by a type name with placeholders
&& !base.is_suggestable_infer_ty()
{
let mut removals = vec![(expr.span.with_lo(qpath.qself_span().hi()), String::new())];
if expr.span.with_source_text(cx, |s| s.starts_with('<')) == Some(true) {
// Remove `<`, '>` has already been removed by the existing removal expression.
removals.push((expr.span.with_hi(qpath.qself_span().lo()), String::new()));
}
span_lint_and_then(
cx,
DEFAULT_CONSTRUCTED_UNIT_STRUCTS,
expr.span,
"use of `default` to create a unit struct",
|diag| {
diag.suggest_remove_item(
cx,
expr.span.with_lo(qpath.qself_span().hi()),
diag.multipart_suggestion(
"remove this call to `default`",
removals,
Applicability::MachineApplicable,
);
},