Use an explicit receiver in DropGuard::dismiss

This commit is contained in:
nxsaken 2025-12-13 14:00:44 +04:00
parent e163707c70
commit 0ecf91a701
2 changed files with 7 additions and 7 deletions

View file

@ -79,30 +79,30 @@ where
///
/// let value = String::from("Nori likes chicken");
/// let guard = DropGuard::new(value, |s| println!("{s}"));
/// assert_eq!(guard.dismiss(), "Nori likes chicken");
/// assert_eq!(DropGuard::dismiss(guard), "Nori likes chicken");
/// ```
#[unstable(feature = "drop_guard", issue = "144426")]
#[rustc_const_unstable(feature = "const_drop_guard", issue = "none")]
#[inline]
pub const fn dismiss(self) -> T
pub const fn dismiss(guard: Self) -> T
where
F: [const] Destruct,
{
// First we ensure that dropping the guard will not trigger
// its destructor
let mut this = ManuallyDrop::new(self);
let mut guard = ManuallyDrop::new(guard);
// Next we manually read the stored value from the guard.
//
// SAFETY: this is safe because we've taken ownership of the guard.
let value = unsafe { ManuallyDrop::take(&mut this.inner) };
let value = unsafe { ManuallyDrop::take(&mut guard.inner) };
// Finally we drop the stored closure. We do this *after* having read
// the value, so that even if the closure's `drop` function panics,
// unwinding still tries to drop the value.
//
// SAFETY: this is safe because we've taken ownership of the guard.
unsafe { ManuallyDrop::drop(&mut this.f) };
unsafe { ManuallyDrop::drop(&mut guard.f) };
value
}
}

View file

@ -815,7 +815,7 @@ fn drop_guard_into_inner() {
let dropped = Cell::new(false);
let value = DropGuard::new(42, |_| dropped.set(true));
let guard = DropGuard::new(value, |_| dropped.set(true));
let inner = guard.dismiss();
let inner = DropGuard::dismiss(guard);
assert_eq!(dropped.get(), false);
assert_eq!(*inner, 42);
}
@ -837,7 +837,7 @@ fn drop_guard_always_drops_value_if_closure_drop_unwinds() {
// run the destructor of the value we passed, which we validate.
let _ = std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
let guard = DropGuard::new(value_with_tracked_destruction, closure_that_panics_on_drop);
guard.dismiss();
DropGuard::dismiss(guard);
}));
assert!(value_was_dropped);
}