From 0f40a12ea35d0a33cef29dc50787ed6efd74cbfd Mon Sep 17 00:00:00 2001 From: Josh Triplett Date: Sat, 1 Sep 2018 12:17:57 -0700 Subject: [PATCH] tidy: Use is_empty() instead of len tests Fixes a clippy warning, and improves readability. --- src/tools/tidy/src/deps.rs | 2 +- src/tools/tidy/src/features.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tools/tidy/src/deps.rs b/src/tools/tidy/src/deps.rs index 68a4b7898575..5bff8480d591 100644 --- a/src/tools/tidy/src/deps.rs +++ b/src/tools/tidy/src/deps.rs @@ -239,7 +239,7 @@ pub fn check_whitelist(path: &Path, cargo: &Path, bad: &mut bool) { unapproved.append(&mut bad); } - if unapproved.len() > 0 { + if !unapproved.is_empty() { println!("Dependencies not on the whitelist:"); for dep in unapproved { println!("* {}", dep.id_str()); diff --git a/src/tools/tidy/src/features.rs b/src/tools/tidy/src/features.rs index c95f1c7b32a9..05eeae7d6b01 100644 --- a/src/tools/tidy/src/features.rs +++ b/src/tools/tidy/src/features.rs @@ -133,7 +133,7 @@ pub fn check(path: &Path, bad: &mut bool, quiet: bool) { name); } - if gate_untested.len() > 0 { + if !gate_untested.is_empty() { tidy_error!(bad, "Found {} features without a gate test.", gate_untested.len()); }