user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rollup merge of #146172 - RalfJung:triagebot-keyword-mentions, r=Urgau

Browse source 
triagebot: configure some pings when certain attributes are used

Let's try this out in practice. :)

Cc `@rust-lang/miri` `@rust-lang/wg-const-eval` `@Urgau`
This commit is contained in:
Stuart Cook 2025-09-04 10:02:06 +10:00 • committed by GitHub
commit 11ea57363b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/tools/tidy/src/triagebot.rs
View file

@ -19,7 +19,12 @@ pub fn check(path: &Path, bad: &mut bool) {
// Check [mentions."*"] sections, i.e. [mentions."compiler/rustc_const_eval/src/"]
if let Some(Value::Table(mentions)) = config.get("mentions") {
for path_str in mentions.keys() {
for (entry_key, entry_val) in mentions.iter() {
// If the type is set to something other than "filename", then this is not a path.
if entry_val.get("type").is_some_and(|t| t.as_str().unwrap_or_default() != "filename") {
continue;
}
let path_str = entry_key;
// Remove quotes from the path
let clean_path = path_str.trim_matches('"');
let full_path = path.join(clean_path);

15
triagebot.toml
View file

@ -1306,6 +1306,21 @@ cc = ["@m-ou-se"]
[mentions."compiler/rustc_ast_lowering/src/format.rs"]
cc = ["@m-ou-se"]
[mentions."#[miri::intrinsic_fallback_is_spec]"]
type = "content"
message = """
`#[miri::intrinsic_fallback_is_spec]` must only be used if the function actively checks for all UB cases,
and explores the possible non-determinism of the intrinsic.
"""
cc = ["@rust-lang/miri"]
[mentions."#[rustc_allow_const_fn_unstable]"]
type = "content"
message = """
`#[rustc_allow_const_fn_unstable]` needs careful audit to avoid accidentally exposing unstable
implementation details on stable.
"""
cc = ["@rust-lang/wg-const-eval"]
# ------------------------------------------------------------------------------
# PR assignments