user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

check earlier for PartialEq where Rhs != Self

Browse source
This commit is contained in:
Ada Alakbarova 2025-10-01 22:54:50 +02:00
parent 097f2fd2f4
commit 16880f7594
No known key found for this signature in database
1 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

15
clippy_lints/src/non_canonical_impls.rs
View file

@ -5,7 +5,7 @@ use clippy_utils::{is_from_proc_macro, last_path_segment, std_or_core};
use rustc_errors::Applicability;
use rustc_hir::{Block, Body, Expr, ExprKind, ImplItem, ImplItemKind, Item, LangItem, Node, UnOp};
use rustc_lint::{LateContext, LateLintPass, LintContext};
use rustc_middle::ty::{EarlyBinder, TraitRef, TypeckResults};
use rustc_middle::ty::{EarlyBinder, TypeckResults};
use rustc_session::declare_lint_pass;
use rustc_span::sym;
use rustc_span::symbol::kw;
@ -129,11 +129,14 @@ impl LateLintPass<'_> for NonCanonicalImpls {
{
check_clone_on_copy(cx, impl_item, block);
} else if trait_name == Some(sym::PartialOrd)
// If `Self` and `Rhs` are not the same type, then a corresponding `Ord` impl is not possible,
// since it doesn't have an `Rhs`
&& let [lhs, rhs] = trait_impl.args.as_slice() && lhs == rhs
&& impl_item.ident.name == sym::partial_cmp
&& let Some(ord_def_id) = cx.tcx.get_diagnostic_item(sym::Ord)
&& implements_trait(cx, trait_impl.self_ty(), ord_def_id, &[])
{
check_partial_ord_on_ord(cx, impl_item, item, &trait_impl, body, block);
check_partial_ord_on_ord(cx, impl_item, item, body, block);
}
}
}
@ -179,7 +182,6 @@ fn check_partial_ord_on_ord<'tcx>(
cx: &LateContext<'tcx>,
impl_item: &ImplItem<'_>,
item: &Item<'_>,
trait_impl: &TraitRef<'_>,
body: &Body<'_>,
block: &Block<'tcx>,
) {
@ -205,13 +207,6 @@ fn check_partial_ord_on_ord<'tcx>(
{
return;
}
// If `Self` and `Rhs` are not the same type, bail. This makes creating a valid
// suggestion tons more complex.
else if let [lhs, rhs, ..] = trait_impl.args.as_slice()
&& lhs != rhs
{
return;
}
span_lint_and_then(
cx,