user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fix flycheck diagnostics flickering for binary targets

Browse source
This commit is contained in:
Lukas Wirth 2024-12-28 18:13:12 +01:00
parent eea4a9ab9e
commit 171be2bd58
1 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/tools/rust-analyzer/crates/rust-analyzer/src/flycheck.rs
View file

@ -345,6 +345,7 @@ impl FlycheckActor {
);
}
if self.package_status.is_empty() {
tracing::trace!(flycheck_id = self.id, "clearing diagnostics");
// We finished without receiving any diagnostics.
// That means all of them are stale.
self.send(FlycheckMessage::ClearDiagnostics {
@ -354,6 +355,11 @@ impl FlycheckActor {
} else {
for (package_id, status) in mem::take(&mut self.package_status) {
if let DiagnosticReceived::No = status {
tracing::trace!(
flycheck_id = self.id,
package_id = package_id.repr,
"clearing diagnostics"
);
self.send(FlycheckMessage::ClearDiagnostics {
id: self.id,
package_id: Some(package_id),
@ -385,9 +391,15 @@ impl FlycheckActor {
"diagnostic received"
);
if let Some(package_id) = &package_id {
if !self.package_status.contains_key(package_id) {
self.package_status
.insert(package_id.clone(), DiagnosticReceived::Yes);
if let None | Some(DiagnosticReceived::No) = self
.package_status
.insert(package_id.clone(), DiagnosticReceived::Yes)
{
tracing::trace!(
flycheck_id = self.id,
package_id = package_id.repr,
"clearing diagnostics"
);
self.send(FlycheckMessage::ClearDiagnostics {
id: self.id,
package_id: Some(package_id.clone()),