user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

make DeferredCommand a must use and move mark_as_executed inside finish process

Browse source
This commit is contained in:
bit-aloo 2025-06-25 00:52:02 +05:30
parent 28f97108f1
commit 18090924f9
No known key found for this signature in database
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/bootstrap/src/utils/execution_context.rs
View file

@ -40,6 +40,7 @@ enum CommandState<'a> {
},
}
#[must_use]
pub struct DeferredCommand<'a> {
state: CommandState<'a>,
}
@ -122,11 +123,11 @@ impl ExecutionContext {
stdout: OutputMode,
stderr: OutputMode,
) -> DeferredCommand<'a> {
command.mark_as_executed();
let cache_key = command.cache_key();
if let Some(cached_output) = cache_key.as_ref().and_then(|key| self.command_cache.get(key))
{
command.mark_as_executed();
self.verbose(|| println!("Cache hit: {command:?}"));
return DeferredCommand { state: CommandState::Cached(cached_output) };
}
@ -244,6 +245,8 @@ impl<'a> DeferredCommand<'a> {
executed_at: &'a std::panic::Location<'a>,
exec_ctx: &ExecutionContext,
) -> CommandOutput {
command.mark_as_executed();
let process = match process.take() {
Some(p) => p,
None => return CommandOutput::default(),