user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Replace FIXME with explanation

Browse source
This commit is contained in:
Dylan MacKenzie 2020-02-17 13:35:49 -08:00
parent 7f3ec5e50b
commit 186cbfad89
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/librustc_typeck/astconv.rs
View file

@ -1345,7 +1345,8 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
let (assoc_ident, def_scope) =
tcx.adjust_ident_and_get_scope(binding.item_name, candidate.def_id(), hir_ref_id);
// FIXME(ecstaticmorse): Can this use `find_by_name_and_kind` instead?
// We have already adjusted the item name above, so compare with `ident.modern()` instead
// of calling `filter_by_name_and_kind`.
let assoc_ty = tcx
.associated_items(candidate.def_id())
.filter_by_name_unhygienic(assoc_ident.name)
@ -2198,7 +2199,8 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
let (assoc_ident, def_scope) =
tcx.adjust_ident_and_get_scope(assoc_ident, trait_did, hir_ref_id);
// FIXME(ecstaticmorse): Can this use `find_by_name_and_namespace` instead?
// We have already adjusted the item name above, so compare with `ident.modern()` instead
// of calling `filter_by_name_and_kind`.
let item = tcx
.associated_items(trait_did)
.in_definition_order()