user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix empty needle corner case and add tests

Browse source
This commit is contained in:
y21 2023-11-15 21:10:03 +01:00
parent 676f1f6ef8
commit 1b4e2ef3d7
4 changed files with 203 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
clippy_lints/src/matches/redundant_guards.rs
View file

@ -127,10 +127,13 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, arms: &'tcx [Arm<'tcx>]) {
{
// `arr if arr.starts_with(&[123])` becomes [123, ..]
// `arr if arr.ends_with(&[123])` becomes [.., 123]
// `arr if arr.starts_with(&[])` becomes [..] (why would anyone write this?)
let mut sugg = snippet(cx, needle.span, "<needle>").into_owned();
if path.ident.name == sym!(starts_with) {
if needles.is_empty() {
sugg.insert_str(1, "..");
} else if path.ident.name == sym!(starts_with) {
sugg.insert_str(sugg.len() - 1, ", ..");
} else if path.ident.name == sym!(ends_with) {
sugg.insert_str(1, ".., ");