user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Auto merge of #6443 - matthiaskrgr:clone_on_copy_type, r=ebroto

Browse source 
clone_on_copy: show the type in the lint message

changelog: clone_on_copy: show the type in the lint message
This commit is contained in:
bors 2020-12-13 16:47:33 +00:00
commit 1df2e38219
3 changed files with 19 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

16
clippy_lints/src/methods/mod.rs
View file

@ -2177,11 +2177,17 @@ fn lint_clone_on_copy(cx: &LateContext<'_>, expr: &hir::Expr<'_>, arg: &hir::Exp
} else {
snip = None;
}
span_lint_and_then(cx, CLONE_ON_COPY, expr.span, "using `clone` on a `Copy` type", |diag| {
if let Some((text, snip)) = snip {
diag.span_suggestion(expr.span, text, snip, Applicability::MachineApplicable);
}
});
span_lint_and_then(
cx,
CLONE_ON_COPY,
expr.span,
&format!("using `clone` on type `{}` which implements the `Copy` trait", ty),
|diag| {
if let Some((text, snip)) = snip {
diag.span_suggestion(expr.span, text, snip, Applicability::MachineApplicable);
}
},
);
}
}