add new lint, empty_enum_variants_with_brackets
- Add a new early pass lint. - Add relevant UI tests.
This commit is contained in:
parent
174a0d7be6
commit
1ee9993a96
7 changed files with 148 additions and 6 deletions
27
tests/ui/empty_enum_variants_with_brackets.fixed
Normal file
27
tests/ui/empty_enum_variants_with_brackets.fixed
Normal file
|
|
@ -0,0 +1,27 @@
|
|||
#![warn(clippy::empty_enum_variants_with_brackets)]
|
||||
#![allow(dead_code)]
|
||||
|
||||
pub enum PublicTestEnum {
|
||||
NonEmptyBraces { x: i32, y: i32 }, // No error
|
||||
NonEmptyParentheses(i32, i32), // No error
|
||||
EmptyBraces, //~ ERROR: enum variant has empty brackets
|
||||
EmptyParentheses, //~ ERROR: enum variant has empty brackets
|
||||
}
|
||||
|
||||
enum TestEnum {
|
||||
NonEmptyBraces { x: i32, y: i32 }, // No error
|
||||
NonEmptyParentheses(i32, i32), // No error
|
||||
EmptyBraces, //~ ERROR: enum variant has empty brackets
|
||||
EmptyParentheses, //~ ERROR: enum variant has empty brackets
|
||||
AnotherEnum, // No error
|
||||
}
|
||||
|
||||
enum TestEnumWithFeatures {
|
||||
NonEmptyBraces {
|
||||
#[cfg(feature = "thisisneverenabled")]
|
||||
x: i32,
|
||||
}, // No error
|
||||
NonEmptyParentheses(#[cfg(feature = "thisisneverenabled")] i32), // No error
|
||||
}
|
||||
|
||||
fn main() {}
|
||||
27
tests/ui/empty_enum_variants_with_brackets.rs
Normal file
27
tests/ui/empty_enum_variants_with_brackets.rs
Normal file
|
|
@ -0,0 +1,27 @@
|
|||
#![warn(clippy::empty_enum_variants_with_brackets)]
|
||||
#![allow(dead_code)]
|
||||
|
||||
pub enum PublicTestEnum {
|
||||
NonEmptyBraces { x: i32, y: i32 }, // No error
|
||||
NonEmptyParentheses(i32, i32), // No error
|
||||
EmptyBraces {}, //~ ERROR: enum variant has empty brackets
|
||||
EmptyParentheses(), //~ ERROR: enum variant has empty brackets
|
||||
}
|
||||
|
||||
enum TestEnum {
|
||||
NonEmptyBraces { x: i32, y: i32 }, // No error
|
||||
NonEmptyParentheses(i32, i32), // No error
|
||||
EmptyBraces {}, //~ ERROR: enum variant has empty brackets
|
||||
EmptyParentheses(), //~ ERROR: enum variant has empty brackets
|
||||
AnotherEnum, // No error
|
||||
}
|
||||
|
||||
enum TestEnumWithFeatures {
|
||||
NonEmptyBraces {
|
||||
#[cfg(feature = "thisisneverenabled")]
|
||||
x: i32,
|
||||
}, // No error
|
||||
NonEmptyParentheses(#[cfg(feature = "thisisneverenabled")] i32), // No error
|
||||
}
|
||||
|
||||
fn main() {}
|
||||
36
tests/ui/empty_enum_variants_with_brackets.stderr
Normal file
36
tests/ui/empty_enum_variants_with_brackets.stderr
Normal file
|
|
@ -0,0 +1,36 @@
|
|||
error: enum variant has empty brackets
|
||||
--> $DIR/empty_enum_variants_with_brackets.rs:7:16
|
||||
|
|
||||
LL | EmptyBraces {},
|
||||
| ^^^
|
||||
|
|
||||
= note: `-D clippy::empty-enum-variants-with-brackets` implied by `-D warnings`
|
||||
= help: to override `-D warnings` add `#[allow(clippy::empty_enum_variants_with_brackets)]`
|
||||
= help: remove the brackets
|
||||
|
||||
error: enum variant has empty brackets
|
||||
--> $DIR/empty_enum_variants_with_brackets.rs:8:21
|
||||
|
|
||||
LL | EmptyParentheses(),
|
||||
| ^^
|
||||
|
|
||||
= help: remove the brackets
|
||||
|
||||
error: enum variant has empty brackets
|
||||
--> $DIR/empty_enum_variants_with_brackets.rs:14:16
|
||||
|
|
||||
LL | EmptyBraces {},
|
||||
| ^^^
|
||||
|
|
||||
= help: remove the brackets
|
||||
|
||||
error: enum variant has empty brackets
|
||||
--> $DIR/empty_enum_variants_with_brackets.rs:15:21
|
||||
|
|
||||
LL | EmptyParentheses(),
|
||||
| ^^
|
||||
|
|
||||
= help: remove the brackets
|
||||
|
||||
error: aborting due to 4 previous errors
|
||||
|
||||
Loading…
Add table
Add a link
Reference in a new issue