user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pr feedback - remove the commented out vcombine_f16

Browse source
This commit is contained in:
James Barford-Evans 2025-03-25 08:43:09 +00:00 • committed by Amanieu d'Antras
parent 08b9752ee1
commit 2099eccb2e
1 changed files with 2 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

19
library/stdarch/crates/core_arch/src/arm_shared/neon/mod.rs
View file

@ -1190,20 +1190,6 @@ impl_sign_conversions_neon! {
(uint8x8x4_t, int8x8x4_t)
}
/* FIXME: 16-bit float
/// Vector combine
#[inline]
#[target_feature(enable = "neon")]
#[cfg_attr(target_arch = "arm", target_feature(enable = "v7"))]
#[cfg_attr(test, assert_instr(nop))]
#[cfg_attr(
target_arch = "arm",
unstable(feature = "stdarch_arm_neon_intrinsics", issue = "111800")
)] pub fn vcombine_f16 ( low: float16x4_t, high: float16x4_t) -> float16x8_t {
unsafe { simd_shuffle!(low, high, [0, 1, 2, 3, 4, 5, 6, 7]) }
}
*/
#[cfg(test)]
mod tests {
use super::*;
@ -5512,9 +5498,8 @@ mod tests {
test_vcombine!(test_vcombine_s16 => vcombine_s16([3_i16, -4, 5, -6], [13_i16, -14, 15, -16]));
test_vcombine!(test_vcombine_u16 => vcombine_u16([3_u16, 4, 5, 6], [13_u16, 14, 15, 16]));
test_vcombine!(test_vcombine_p16 => vcombine_p16([3_u16, 4, 5, 6], [13_u16, 14, 15, 16]));
// FIXME: 16-bit floats
// test_vcombine!(test_vcombine_f16 => vcombine_f16([3_f16, 4., 5., 6.],
// [13_f16, 14., 15., 16.]));
test_vcombine!(test_vcombine_f16 => vcombine_f16([3_f16, 4., 5., 6.],
[13_f16, 14., 15., 16.]));
test_vcombine!(test_vcombine_s32 => vcombine_s32([3_i32, -4], [13_i32, -14]));
test_vcombine!(test_vcombine_u32 => vcombine_u32([3_u32, 4], [13_u32, 14]));