user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle lints, not passes in push_lints

Browse source 
This extracts the call to get_lints() to callers.
This commit is contained in:
Mark Rousskov 2019-09-24 18:24:45 -04:00
parent 577d442fe8
commit 2121b04751
1 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/librustc/lint/context.rs
View file

@ -172,7 +172,7 @@ impl LintStore {
from_plugin: bool,
register_only: bool,
pass: EarlyLintPassObject) {
self.push_pass(from_plugin, &pass);
self.push_lints(from_plugin, &pass.get_lints());
if !register_only {
self.early_passes.as_mut().unwrap().push(pass);
}
@ -184,7 +184,7 @@ impl LintStore {
register_only: bool,
pass: EarlyLintPassObject,
) {
self.push_pass(from_plugin, &pass);
self.push_lints(from_plugin, &pass.get_lints());
if !register_only {
self.pre_expansion_passes.as_mut().unwrap().push(pass);
}
@ -195,7 +195,7 @@ impl LintStore {
register_only: bool,
per_module: bool,
pass: LateLintPassObject) {
self.push_pass(from_plugin, &pass);
self.push_lints(from_plugin, &pass.get_lints());
if !register_only {
if per_module {
self.late_module_passes.push(pass);
@ -206,10 +206,8 @@ impl LintStore {
}
// Helper method for register_early/late_pass
fn push_pass<P: LintPass + ?Sized + 'static>(&mut self,
from_plugin: bool,
pass: &Box<P>) {
for lint in pass.get_lints() {
fn push_lints(&mut self, from_plugin: bool, lints: &[&'static Lint]) {
for lint in lints {
self.lints.push((lint, from_plugin));
let id = LintId::of(lint);