user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rollup merge of #101624 - notriddle:notriddle/search, r=GuillaumeGomez

Browse source 
rustdoc: remove unused CSS `#search { position: relative }`

This was added in 611d0e6cce, to allow its child `#results` element to be absolutely positioned inside it. The child stopped being absolute in 8c0469552e.

To keep the layout looking the same, the links need to not have `width: 100%` any more, relying instead on the box naturally growing to fit because it has `display: block`.
This commit is contained in:
Matthias Krüger 2022-09-10 07:09:21 +02:00 • committed by GitHub
commit 227e25a8d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/librustdoc/html/static/css/rustdoc.css
View file

@ -592,10 +592,6 @@ h2.location a {
margin: 0;
}
#search {
position: relative;
}
.search-loading {
text-align: center;
}
@ -973,7 +969,6 @@ so that we can apply CSS-filters to change the arrow color in themes */
.search-results > a {
display: block;
width: 100%;
/* A little margin ensures the browser's outlining of focused links has room to display. */
margin-left: 2px;
margin-right: 2px;

4
src/test/rustdoc-gui/search-result-display.goml
View file

@ -7,11 +7,11 @@ press-key: 'Enter'
wait-for: "#crate-search"
// The width is returned by "getComputedStyle" which returns the exact number instead of the
// CSS rule which is "50%"...
assert-css: (".search-results div.desc", {"width": "295px"})
assert-css: (".search-results div.desc", {"width": "293px"})
size: (600, 100)
// As counter-intuitive as it may seem, in this width, the width is "100%", which is why
// when computed it's larger.
assert-css: (".search-results div.desc", {"width": "570px"})
assert-css: (".search-results div.desc", {"width": "566px"})
// Check that the crate filter `<select>` is correctly handled when it goes to next line.
// To do so we need to update the length of one of its `<option>`.