user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify DefaultNumericFallback

Browse source
This commit is contained in:
Yoshitomo Nakanishi 2021-02-07 18:00:08 +09:00
parent 8b8b0a94b0
commit 22d4483dee
4 changed files with 61 additions and 612 deletions
Download patch file Download diff file Expand all files Collapse all files

101
tests/ui/default_numeric_fallback.rs
View file

@ -1,99 +1,18 @@
#![warn(clippy::default_numeric_fallback)]
#![allow(unused)]
#![allow(clippy::never_loop)]
#![allow(clippy::no_effect)]
#![allow(clippy::unnecessary_operation)]
fn ret_i31() -> i32 {
23
}
fn concrete_arg(x: i32) {}
fn generic_arg<T>(t: T) {}
struct ConcreteStruct {
x: i32,
}
struct GenericStruct<T> {
x: T,
}
struct StructForMethodCallTest {
x: i32,
}
impl StructForMethodCallTest {
fn concrete_arg(&self, x: i32) {}
fn generic_arg<T>(&self, t: T) {}
}
fn main() {
let s = StructForMethodCallTest { x: 10_i32 };
// Bad.
let x = 22;
let x = 0.12;
let x: _ = 13;
let x: [_; 3] = [1, 2, 3];
let x: (_, i32) = (1, 2);
let x = if true { (1, 2) } else { (3, 4) };
let x = match 1 {
1 => 1,
_ => 2,
};
let x = loop {
break 1;
};
let x = 'outer0: loop {
{
'inner0: loop {
break 3;
}
};
break 2;
};
let x = GenericStruct { x: 1 };
generic_arg(10);
s.generic_arg(10);
let f = || -> _ { 1 };
let x = 1;
let x = 0.1;
let x = if true { 1 } else { 2 };
// Good.
let x = 22_i32;
let x: f64 = 0.12;
let x = 0.12_f64;
let x: i32 = 13;
let x: [i32; 3] = [1, 2, 3];
let x: (i32, i32) = (1, 2);
let x: (i32, i32) = if true { (1, 2) } else { (3, 4) };
let x: i32 = match true {
true => 1,
_ => 2,
};
let x: i32 = loop {
break 1;
};
let x: i32 = 'outer1: loop {
'inner1: loop {
break 'outer1 3;
}
};
let x = ConcreteStruct { x: 1 };
concrete_arg(10);
s.concrete_arg(10);
let f = || -> i32 { 1 };
let x = 1_i32;
let x: i32 = 1;
let x: _ = 1;
let x = 0.1_f64;
let x: f64 = 0.1;
let x: _ = 0.1;
let x: _ = if true { 1 } else { 2 };
}

176
tests/ui/default_numeric_fallback.stderr
View file

@ -1,187 +1,35 @@
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:37:13
--> $DIR/default_numeric_fallback.rs:6:13
|
LL | let x = 22;
| ^^
LL | let x = 1;
| ^
|
= note: `-D clippy::default-numeric-fallback` implied by `-D warnings`
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:38:13
--> $DIR/default_numeric_fallback.rs:7:13
|
LL | let x = 0.12;
| ^^^^
LL | let x = 0.1;
| ^^^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:39:16
--> $DIR/default_numeric_fallback.rs:8:23
|
LL | let x: _ = 13;
| ^^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:40:22
|
LL | let x: [_; 3] = [1, 2, 3];
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:40:25
|
LL | let x: [_; 3] = [1, 2, 3];
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:40:28
|
LL | let x: [_; 3] = [1, 2, 3];
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:41:24
|
LL | let x: (_, i32) = (1, 2);
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:41:27
|
LL | let x: (_, i32) = (1, 2);
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:43:24
|
LL | let x = if true { (1, 2) } else { (3, 4) };
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:43:27
|
LL | let x = if true { (1, 2) } else { (3, 4) };
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:43:40
|
LL | let x = if true { (1, 2) } else { (3, 4) };
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:43:43
|
LL | let x = if true { (1, 2) } else { (3, 4) };
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:45:19
|
LL | let x = match 1 {
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:46:9
|
LL | 1 => 1,
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:46:14
|
LL | 1 => 1,
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:47:14
|
LL | _ => 2,
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:51:15
|
LL | break 1;
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:57:23
|
LL | break 3;
LL | let x = if true { 1 } else { 2 };
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:60:15
--> $DIR/default_numeric_fallback.rs:8:34
|
LL | break 2;
| ^
LL | let x = if true { 1 } else { 2 };
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:63:32
|
LL | let x = GenericStruct { x: 1 };
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:65:17
|
LL | generic_arg(10);
| ^^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:66:19
|
LL | s.generic_arg(10);
| ^^
|
= help: consider adding suffix to avoid default numeric fallback
error: default numeric fallback might occur
--> $DIR/default_numeric_fallback.rs:67:23
|
LL | let f = || -> _ { 1 };
| ^
|
= help: consider adding suffix to avoid default numeric fallback
error: aborting due to 23 previous errors
error: aborting due to 4 previous errors