From 2490ee5080ef1810fc137c676f4906d65a407dde Mon Sep 17 00:00:00 2001 From: Niko Matsakis Date: Tue, 2 May 2017 21:25:15 -0400 Subject: [PATCH] correct various error messages that changed The new messages seem universally better. I think these result because we recognize that we are in an invariant context more often. --- .../compile-fail/region-invariant-static-error-reporting.rs | 5 ++--- src/test/compile-fail/regions-trait-object-subtyping.rs | 2 +- src/test/compile-fail/variance-contravariant-arg-object.rs | 4 ++-- src/test/compile-fail/variance-covariant-arg-object.rs | 4 ++-- src/test/compile-fail/variance-invariant-arg-object.rs | 4 ++-- 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/test/compile-fail/region-invariant-static-error-reporting.rs b/src/test/compile-fail/region-invariant-static-error-reporting.rs index d25674a74b1d..646ae8183a20 100644 --- a/src/test/compile-fail/region-invariant-static-error-reporting.rs +++ b/src/test/compile-fail/region-invariant-static-error-reporting.rs @@ -13,9 +13,8 @@ // over time, but this test used to exhibit some pretty bogus messages // that were not remotely helpful. -// error-pattern:cannot infer -// error-pattern:cannot outlive the lifetime 'a -// error-pattern:must be valid for the static lifetime +// error-pattern:the lifetime 'a +// error-pattern:the static lifetime struct Invariant<'a>(Option<&'a mut &'a mut ()>); diff --git a/src/test/compile-fail/regions-trait-object-subtyping.rs b/src/test/compile-fail/regions-trait-object-subtyping.rs index e8ada6a17557..948fb7e1ef6c 100644 --- a/src/test/compile-fail/regions-trait-object-subtyping.rs +++ b/src/test/compile-fail/regions-trait-object-subtyping.rs @@ -22,7 +22,7 @@ fn foo2<'a:'b,'b>(x: &'b mut (Dummy+'a)) -> &'b mut (Dummy+'b) { fn foo3<'a,'b>(x: &'a mut Dummy) -> &'b mut Dummy { // Without knowing 'a:'b, we can't coerce - x //~ ERROR cannot infer an appropriate lifetime + x //~ ERROR lifetime bound not satisfied //~^ ERROR cannot infer an appropriate lifetime } diff --git a/src/test/compile-fail/variance-contravariant-arg-object.rs b/src/test/compile-fail/variance-contravariant-arg-object.rs index d3bf92e85f41..1795ac95358d 100644 --- a/src/test/compile-fail/variance-contravariant-arg-object.rs +++ b/src/test/compile-fail/variance-contravariant-arg-object.rs @@ -21,7 +21,7 @@ fn get_min_from_max<'min, 'max>(v: Box>) -> Box> where 'max : 'min { - v //~ ERROR cannot infer an appropriate lifetime + v //~ ERROR mismatched types } fn get_max_from_min<'min, 'max, G>(v: Box>) @@ -29,7 +29,7 @@ fn get_max_from_min<'min, 'max, G>(v: Box>) where 'max : 'min { // Previously OK: - v //~ ERROR cannot infer an appropriate lifetime + v //~ ERROR mismatched types } fn main() { } diff --git a/src/test/compile-fail/variance-covariant-arg-object.rs b/src/test/compile-fail/variance-covariant-arg-object.rs index 0e94e35df283..ad059a467f57 100644 --- a/src/test/compile-fail/variance-covariant-arg-object.rs +++ b/src/test/compile-fail/variance-covariant-arg-object.rs @@ -22,14 +22,14 @@ fn get_min_from_max<'min, 'max>(v: Box>) where 'max : 'min { // Previously OK, now an error as traits are invariant. - v //~ ERROR cannot infer an appropriate lifetime + v //~ ERROR mismatched types } fn get_max_from_min<'min, 'max, G>(v: Box>) -> Box> where 'max : 'min { - v //~ ERROR cannot infer an appropriate lifetime + v //~ ERROR mismatched types } fn main() { } diff --git a/src/test/compile-fail/variance-invariant-arg-object.rs b/src/test/compile-fail/variance-invariant-arg-object.rs index aa3e06c015d5..9edb510b826a 100644 --- a/src/test/compile-fail/variance-invariant-arg-object.rs +++ b/src/test/compile-fail/variance-invariant-arg-object.rs @@ -18,14 +18,14 @@ fn get_min_from_max<'min, 'max>(v: Box>) -> Box> where 'max : 'min { - v //~ ERROR cannot infer an appropriate lifetime + v //~ ERROR mismatched types } fn get_max_from_min<'min, 'max, G>(v: Box>) -> Box> where 'max : 'min { - v //~ ERROR cannot infer an appropriate lifetime + v //~ ERROR mismatched types } fn main() { }