user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Only build suggestion if necessary in USELESS_VEC

Browse source
This commit is contained in:
mcarton 2016-06-30 19:50:03 +02:00
parent 98f18f0474
commit 28bd591f05
No known key found for this signature in database
GPG key ID: 5E427C794CBA45E8
1 changed files with 19 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

38
clippy_lints/src/vec.rs
View file

@ -51,26 +51,26 @@ impl LateLintPass for Pass {
fn check_vec_macro(cx: &LateContext, vec: &Expr, span: Span) {
if let Some(vec_args) = higher::vec_macro(cx, vec) {
let snippet = match vec_args {
higher::VecArgs::Repeat(elem, len) => {
format!("&[{}; {}]", snippet(cx, elem.span, "elem"), snippet(cx, len.span, "len")).into()
}
higher::VecArgs::Vec(args) => {
if let Some(last) = args.iter().last() {
let span = Span {
lo: args[0].span.lo,
hi: last.span.hi,
expn_id: args[0].span.expn_id,
};
format!("&[{}]", snippet(cx, span, "..")).into()
} else {
"&[]".into()
}
}
};
span_lint_and_then(cx, USELESS_VEC, span, "useless use of `vec!`", |db| {
let snippet = match vec_args {
higher::VecArgs::Repeat(elem, len) => {
format!("&[{}; {}]", snippet(cx, elem.span, "elem"), snippet(cx, len.span, "len")).into()
}
higher::VecArgs::Vec(args) => {
if let Some(last) = args.iter().last() {
let span = Span {
lo: args[0].span.lo,
hi: last.span.hi,
expn_id: args[0].span.expn_id,
};
format!("&[{}]", snippet(cx, span, "..")).into()
} else {
"&[]".into()
}
}
};
db.span_suggestion(span, "you can use a slice directly", snippet);
});
}