user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

needless_pass_by_value: Add suggestion for implementing Copy (fixes #2222)

Browse source
This commit is contained in:
Manish Goregaokar 2018-01-18 14:15:41 +05:30
parent cf1fbaa36a
commit 2a30c8a194
2 changed files with 31 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
clippy_lints/src/needless_pass_by_value.rs
View file

@ -202,6 +202,13 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
// Dereference suggestion
let sugg = |db: &mut DiagnosticBuilder| {
if let ty::TypeVariants::TyAdt(ref def, ..) = ty.sty {
if let Some(span) = cx.tcx.hir.span_if_local(def.did) {
// FIXME (#2374) Restrict this to types which can impl Copy
db.span_help(span, "consider marking this type as Copy if possible");
}
}
let deref_span = spans_need_deref.get(&canonical_id);
if_chain! {
if match_type(cx, ty, &paths::VEC);