user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

improve early lint to use multispan from diagnostic

Browse source
This commit is contained in:
Niko Matsakis 2016-10-13 12:08:50 -04:00
parent 0aeab9a390
commit 2b5bc487c5
5 changed files with 36 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/librustc/session/mod.rs
View file

@ -258,16 +258,25 @@ impl Session {
pub fn unimpl(&self, msg: &str) -> ! {
self.diagnostic().unimpl(msg)
}
pub fn add_lint<M: lint::EarlyLintMessage>(&self,
lint: &'static lint::Lint,
id: ast::NodeId,
sp: Span,
msg: M) {
pub fn add_lint(&self,
lint: &'static lint::Lint,
id: ast::NodeId,
sp: Span,
msg: String)
{
self.add_lint_diagnostic(lint, id, (sp, &msg[..]))
}
pub fn add_lint_diagnostic<M>(&self,
lint: &'static lint::Lint,
id: ast::NodeId,
msg: M)
where M: lint::IntoEarlyLint,
{
let lint_id = lint::LintId::of(lint);
let mut lints = self.lints.borrow_mut();
let early_lint = lint::EarlyLint::new(lint_id, sp, msg);
let early_lint = msg.into_early_lint(lint_id);
if let Some(arr) = lints.get_mut(&id) {
if !arr.iter().any(|l| l.matches(&early_lint)) {
if !arr.contains(&early_lint) {
arr.push(early_lint);
}
return;