user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix a bug in abs_diff

Browse source 
These were taken from `compiler-builtins` but the implementation has a
bug near the integer limits. Fixed in `compiler-builtins` by using
`core`'s implementation at [1], this is the corresponding fix for
`libm`.

[1]: https://github.com/rust-lang/compiler-builtins/pull/736
This commit is contained in:
Trevor Gross 2024-12-22 22:24:38 +00:00
parent 565d751f8a
commit 2cbacf89af
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
library/compiler-builtins/libm/src/math/support/int_traits.rs
View file

@ -184,7 +184,7 @@ macro_rules! int_impl {
}
fn abs_diff(self, other: Self) -> Self {
if self < other { other.wrapping_sub(self) } else { self.wrapping_sub(other) }
self.abs_diff(other)
}
int_impl_common!($uty);
@ -221,7 +221,7 @@ macro_rules! int_impl {
}
fn abs_diff(self, other: Self) -> $uty {
self.wrapping_sub(other).wrapping_abs() as $uty
self.abs_diff(other)
}
int_impl_common!($ity);