Auto merge of #57577 - Centril:rollup, r=Centril
Rollup of 4 pull requests Successful merges: - #57004 (Make `TokenStream` less recursive.) - #57102 (NLL: Add union justifications to conflicting borrows.) - #57337 (rustc: Place wasm linker args first instead of last) - #57549 (Add #[must_use] message to Iterator and Future) Failed merges: r? @ghost
This commit is contained in:
commit
2cf736f765
28 changed files with 601 additions and 579 deletions
|
|
@ -138,7 +138,7 @@ error[E0502]: cannot borrow `foo` (via `foo.bar2`) as immutable because `foo` is
|
|||
LL | let bar1 = &mut foo.bar1;
|
||||
| -------- mutable borrow occurs here (via `foo.bar1`)
|
||||
LL | let _foo1 = &foo.bar2; //~ ERROR cannot borrow
|
||||
| ^^^^^^^^ immutable borrow occurs here (via `foo.bar2`)
|
||||
| ^^^^^^^^ immutable borrow of `foo.bar2` -- which overlaps with `foo.bar1` -- occurs here
|
||||
LL | *bar1;
|
||||
LL | }
|
||||
| - mutable borrow ends here
|
||||
|
|
|
|||
|
|
@ -61,7 +61,7 @@ error[E0502]: cannot borrow `a` (via `a.y`) as immutable because `a` is also bor
|
|||
LL | let _x = &mut a.x;
|
||||
| --- mutable borrow occurs here (via `a.x`)
|
||||
LL | let _y = &a.y; //[ast]~ ERROR cannot borrow
|
||||
| ^^^ immutable borrow occurs here (via `a.y`)
|
||||
| ^^^ immutable borrow of `a.y` -- which overlaps with `a.x` -- occurs here
|
||||
...
|
||||
LL | }
|
||||
| - mutable borrow ends here
|
||||
|
|
@ -72,7 +72,7 @@ error[E0502]: cannot borrow `a` (via `a.y`) as mutable because `a` is also borro
|
|||
LL | let _x = &a.x;
|
||||
| --- immutable borrow occurs here (via `a.x`)
|
||||
LL | let _y = &mut a.y; //[ast]~ ERROR cannot borrow
|
||||
| ^^^ mutable borrow occurs here (via `a.y`)
|
||||
| ^^^ mutable borrow of `a.y` -- which overlaps with `a.x` -- occurs here
|
||||
...
|
||||
LL | }
|
||||
| - immutable borrow ends here
|
||||
|
|
|
|||
|
|
@ -83,14 +83,14 @@ fn borrow_after_mut_borrow() {
|
|||
let mut a: Box<_> = box A { x: box 0, y: 1 };
|
||||
let _x = &mut a.x;
|
||||
let _y = &a.y; //[ast]~ ERROR cannot borrow
|
||||
//[ast]~^ immutable borrow occurs here (via `a.y`)
|
||||
//[ast]~^ immutable borrow of `a.y` -- which overlaps with `a.x` -- occurs here
|
||||
use_mut(_x);
|
||||
}
|
||||
fn mut_borrow_after_borrow() {
|
||||
let mut a: Box<_> = box A { x: box 0, y: 1 };
|
||||
let _x = &a.x;
|
||||
let _y = &mut a.y; //[ast]~ ERROR cannot borrow
|
||||
//[ast]~^ mutable borrow occurs here (via `a.y`)
|
||||
//[ast]~^ mutable borrow of `a.y` -- which overlaps with `a.x` -- occurs here
|
||||
use_imm(_x);
|
||||
}
|
||||
fn copy_after_move_nested() {
|
||||
|
|
|
|||
|
|
@ -1,132 +1,127 @@
|
|||
error[E0502]: cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
--> $DIR/borrowck-union-borrow.rs:27:23
|
||||
--> $DIR/borrowck-union-borrow.rs:25:23
|
||||
|
|
||||
LL | let ra = &u.a;
|
||||
| ---- immutable borrow occurs here
|
||||
LL | let rma = &mut u.a; //[ast]~ ERROR cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
LL | let rma = &mut u.a; //~ ERROR cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
| ^^^^^^^^ mutable borrow occurs here
|
||||
LL | //[mir]~^ ERROR cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
LL | drop(ra);
|
||||
| -- immutable borrow later used here
|
||||
|
||||
error[E0506]: cannot assign to `u.a` because it is borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:33:13
|
||||
--> $DIR/borrowck-union-borrow.rs:30:13
|
||||
|
|
||||
LL | let ra = &u.a;
|
||||
| ---- borrow of `u.a` occurs here
|
||||
LL | u.a = 1; //[ast]~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
LL | u.a = 1; //~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
| ^^^^^^^ assignment to borrowed `u.a` occurs here
|
||||
LL | //[mir]~^ ERROR cannot assign to `u.a` because it is borrowed
|
||||
LL | drop(ra);
|
||||
| -- borrow later used here
|
||||
|
||||
error[E0502]: cannot borrow `u.b` as mutable because it is also borrowed as immutable
|
||||
--> $DIR/borrowck-union-borrow.rs:50:23
|
||||
error[E0502]: cannot borrow `u` (via `u.b`) as mutable because it is also borrowed as immutable (via `u.a`)
|
||||
--> $DIR/borrowck-union-borrow.rs:46:23
|
||||
|
|
||||
LL | let ra = &u.a;
|
||||
| ---- immutable borrow occurs here
|
||||
LL | let rmb = &mut u.b; //[ast]~ ERROR cannot borrow `u` (via `u.b`) as mutable because `u` is also borrowed as immutable (via `u.a`)
|
||||
| ^^^^^^^^ mutable borrow occurs here
|
||||
LL | //[mir]~^ ERROR cannot borrow `u.b` as mutable because it is also borrowed as immutable
|
||||
| ---- immutable borrow occurs here (via `u.a`)
|
||||
LL | let rmb = &mut u.b; //~ ERROR cannot borrow `u` (via `u.b`) as mutable because `u` is also borrowed as immutable (via `u.a`)
|
||||
| ^^^^^^^^ mutable borrow of `u.b` -- which overlaps with `u.a` -- occurs here
|
||||
LL | drop(ra);
|
||||
| -- immutable borrow later used here
|
||||
|
|
||||
= note: `u.b` is a field of the union `U`, so it overlaps the field `u.a`
|
||||
|
||||
error[E0506]: cannot assign to `u.b` because it is borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:56:13
|
||||
--> $DIR/borrowck-union-borrow.rs:51:13
|
||||
|
|
||||
LL | let ra = &u.a;
|
||||
| ---- borrow of `u.b` occurs here
|
||||
LL | u.b = 1; //[ast]~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
LL | u.b = 1; //~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
| ^^^^^^^ assignment to borrowed `u.b` occurs here
|
||||
LL | //[mir]~^ ERROR cannot assign to `u.b` because it is borrowed
|
||||
LL | drop(ra);
|
||||
| -- borrow later used here
|
||||
|
||||
error[E0502]: cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
--> $DIR/borrowck-union-borrow.rs:63:22
|
||||
--> $DIR/borrowck-union-borrow.rs:57:22
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| -------- mutable borrow occurs here
|
||||
LL | let ra = &u.a; //[ast]~ ERROR cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
LL | let ra = &u.a; //~ ERROR cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
| ^^^^ immutable borrow occurs here
|
||||
LL | //[mir]~^ ERROR cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
LL | drop(rma);
|
||||
| --- mutable borrow later used here
|
||||
|
||||
error[E0503]: cannot use `u.a` because it was mutably borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:69:21
|
||||
--> $DIR/borrowck-union-borrow.rs:62:21
|
||||
|
|
||||
LL | let ra = &mut u.a;
|
||||
| -------- borrow of `u.a` occurs here
|
||||
LL | let a = u.a; //[ast]~ ERROR cannot use `u.a` because it was mutably borrowed
|
||||
LL | let a = u.a; //~ ERROR cannot use `u.a` because it was mutably borrowed
|
||||
| ^^^ use of borrowed `u.a`
|
||||
LL | //[mir]~^ ERROR cannot use `u.a` because it was mutably borrowed
|
||||
LL | drop(ra);
|
||||
| -- borrow later used here
|
||||
|
||||
error[E0499]: cannot borrow `u.a` as mutable more than once at a time
|
||||
--> $DIR/borrowck-union-borrow.rs:75:24
|
||||
--> $DIR/borrowck-union-borrow.rs:67:24
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| -------- first mutable borrow occurs here
|
||||
LL | let rma2 = &mut u.a; //[ast]~ ERROR cannot borrow `u.a` as mutable more than once at a time
|
||||
LL | let rma2 = &mut u.a; //~ ERROR cannot borrow `u.a` as mutable more than once at a time
|
||||
| ^^^^^^^^ second mutable borrow occurs here
|
||||
LL | //[mir]~^ ERROR cannot borrow `u.a` as mutable more than once at a time
|
||||
LL | drop(rma);
|
||||
| --- first borrow later used here
|
||||
|
||||
error[E0506]: cannot assign to `u.a` because it is borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:81:13
|
||||
--> $DIR/borrowck-union-borrow.rs:72:13
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| -------- borrow of `u.a` occurs here
|
||||
LL | u.a = 1; //[ast]~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
LL | u.a = 1; //~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
| ^^^^^^^ assignment to borrowed `u.a` occurs here
|
||||
LL | //[mir]~^ ERROR cannot assign to `u.a` because it is borrowed
|
||||
LL | drop(rma);
|
||||
| --- borrow later used here
|
||||
|
||||
error[E0502]: cannot borrow `u.b` as immutable because it is also borrowed as mutable
|
||||
--> $DIR/borrowck-union-borrow.rs:88:22
|
||||
error[E0502]: cannot borrow `u` (via `u.b`) as immutable because it is also borrowed as mutable (via `u.a`)
|
||||
--> $DIR/borrowck-union-borrow.rs:78:22
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| -------- mutable borrow occurs here
|
||||
LL | let rb = &u.b; //[ast]~ ERROR cannot borrow `u` (via `u.b`) as immutable because `u` is also borrowed as mutable (via `u.a`)
|
||||
| ^^^^ immutable borrow occurs here
|
||||
LL | //[mir]~^ ERROR cannot borrow `u.b` as immutable because it is also borrowed as mutable
|
||||
| -------- mutable borrow occurs here (via `u.a`)
|
||||
LL | let rb = &u.b; //~ ERROR cannot borrow `u` (via `u.b`) as immutable because `u` is also borrowed as mutable (via `u.a`)
|
||||
| ^^^^ immutable borrow of `u.b` -- which overlaps with `u.a` -- occurs here
|
||||
LL | drop(rma);
|
||||
| --- mutable borrow later used here
|
||||
|
|
||||
= note: `u.b` is a field of the union `U`, so it overlaps the field `u.a`
|
||||
|
||||
error[E0503]: cannot use `u.b` because it was mutably borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:94:21
|
||||
--> $DIR/borrowck-union-borrow.rs:83:21
|
||||
|
|
||||
LL | let ra = &mut u.a;
|
||||
| -------- borrow of `u.a` occurs here
|
||||
LL | let b = u.b; //[ast]~ ERROR cannot use `u.b` because it was mutably borrowed
|
||||
LL | let b = u.b; //~ ERROR cannot use `u.b` because it was mutably borrowed
|
||||
| ^^^ use of borrowed `u.a`
|
||||
...
|
||||
LL |
|
||||
LL | drop(ra);
|
||||
| -- borrow later used here
|
||||
|
||||
error[E0499]: cannot borrow `u.b` as mutable more than once at a time
|
||||
--> $DIR/borrowck-union-borrow.rs:101:24
|
||||
error[E0499]: cannot borrow `u` (via `u.b`) as mutable more than once at a time
|
||||
--> $DIR/borrowck-union-borrow.rs:89:24
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| -------- first mutable borrow occurs here
|
||||
LL | let rmb2 = &mut u.b; //[ast]~ ERROR cannot borrow `u` (via `u.b`) as mutable more than once at a time
|
||||
| ^^^^^^^^ second mutable borrow occurs here
|
||||
LL | //[mir]~^ ERROR cannot borrow `u.b` as mutable more than once at a time
|
||||
| -------- first mutable borrow occurs here (via `u.a`)
|
||||
LL | let rmb2 = &mut u.b; //~ ERROR cannot borrow `u` (via `u.b`) as mutable more than once at a time
|
||||
| ^^^^^^^^ second mutable borrow occurs here (via `u.b`)
|
||||
LL | drop(rma);
|
||||
| --- first borrow later used here
|
||||
|
|
||||
= note: `u.b` is a field of the union `U`, so it overlaps the field `u.a`
|
||||
|
||||
error[E0506]: cannot assign to `u.b` because it is borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:107:13
|
||||
--> $DIR/borrowck-union-borrow.rs:94:13
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| -------- borrow of `u.b` occurs here
|
||||
LL | u.b = 1; //[ast]~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
LL | u.b = 1; //~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
| ^^^^^^^ assignment to borrowed `u.b` occurs here
|
||||
LL | //[mir]~^ ERROR cannot assign to `u.b` because it is borrowed
|
||||
LL | drop(rma);
|
||||
| --- borrow later used here
|
||||
|
||||
|
|
@ -1,6 +1,4 @@
|
|||
// ignore-tidy-linelength
|
||||
// revisions: ast mir
|
||||
//[mir]compile-flags: -Z borrowck=mir
|
||||
|
||||
#[derive(Clone, Copy)]
|
||||
union U {
|
||||
|
|
@ -24,14 +22,12 @@ fn main() {
|
|||
}
|
||||
{
|
||||
let ra = &u.a;
|
||||
let rma = &mut u.a; //[ast]~ ERROR cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
//[mir]~^ ERROR cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
let rma = &mut u.a; //~ ERROR cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
drop(ra);
|
||||
}
|
||||
{
|
||||
let ra = &u.a;
|
||||
u.a = 1; //[ast]~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
//[mir]~^ ERROR cannot assign to `u.a` because it is borrowed
|
||||
u.a = 1; //~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
drop(ra);
|
||||
}
|
||||
// Imm borrow, other field
|
||||
|
|
@ -47,65 +43,55 @@ fn main() {
|
|||
}
|
||||
{
|
||||
let ra = &u.a;
|
||||
let rmb = &mut u.b; //[ast]~ ERROR cannot borrow `u` (via `u.b`) as mutable because `u` is also borrowed as immutable (via `u.a`)
|
||||
//[mir]~^ ERROR cannot borrow `u.b` as mutable because it is also borrowed as immutable
|
||||
let rmb = &mut u.b; //~ ERROR cannot borrow `u` (via `u.b`) as mutable because `u` is also borrowed as immutable (via `u.a`)
|
||||
drop(ra);
|
||||
}
|
||||
{
|
||||
let ra = &u.a;
|
||||
u.b = 1; //[ast]~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
//[mir]~^ ERROR cannot assign to `u.b` because it is borrowed
|
||||
u.b = 1; //~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
drop(ra);
|
||||
}
|
||||
// Mut borrow, same field
|
||||
{
|
||||
let rma = &mut u.a;
|
||||
let ra = &u.a; //[ast]~ ERROR cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
//[mir]~^ ERROR cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
let ra = &u.a; //~ ERROR cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
drop(rma);
|
||||
}
|
||||
{
|
||||
let ra = &mut u.a;
|
||||
let a = u.a; //[ast]~ ERROR cannot use `u.a` because it was mutably borrowed
|
||||
//[mir]~^ ERROR cannot use `u.a` because it was mutably borrowed
|
||||
let a = u.a; //~ ERROR cannot use `u.a` because it was mutably borrowed
|
||||
drop(ra);
|
||||
}
|
||||
{
|
||||
let rma = &mut u.a;
|
||||
let rma2 = &mut u.a; //[ast]~ ERROR cannot borrow `u.a` as mutable more than once at a time
|
||||
//[mir]~^ ERROR cannot borrow `u.a` as mutable more than once at a time
|
||||
let rma2 = &mut u.a; //~ ERROR cannot borrow `u.a` as mutable more than once at a time
|
||||
drop(rma);
|
||||
}
|
||||
{
|
||||
let rma = &mut u.a;
|
||||
u.a = 1; //[ast]~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
//[mir]~^ ERROR cannot assign to `u.a` because it is borrowed
|
||||
u.a = 1; //~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
drop(rma);
|
||||
}
|
||||
// Mut borrow, other field
|
||||
{
|
||||
let rma = &mut u.a;
|
||||
let rb = &u.b; //[ast]~ ERROR cannot borrow `u` (via `u.b`) as immutable because `u` is also borrowed as mutable (via `u.a`)
|
||||
//[mir]~^ ERROR cannot borrow `u.b` as immutable because it is also borrowed as mutable
|
||||
let rb = &u.b; //~ ERROR cannot borrow `u` (via `u.b`) as immutable because `u` is also borrowed as mutable (via `u.a`)
|
||||
drop(rma);
|
||||
}
|
||||
{
|
||||
let ra = &mut u.a;
|
||||
let b = u.b; //[ast]~ ERROR cannot use `u.b` because it was mutably borrowed
|
||||
//[mir]~^ ERROR cannot use `u.b` because it was mutably borrowed
|
||||
let b = u.b; //~ ERROR cannot use `u.b` because it was mutably borrowed
|
||||
|
||||
drop(ra);
|
||||
}
|
||||
{
|
||||
let rma = &mut u.a;
|
||||
let rmb2 = &mut u.b; //[ast]~ ERROR cannot borrow `u` (via `u.b`) as mutable more than once at a time
|
||||
//[mir]~^ ERROR cannot borrow `u.b` as mutable more than once at a time
|
||||
let rmb2 = &mut u.b; //~ ERROR cannot borrow `u` (via `u.b`) as mutable more than once at a time
|
||||
drop(rma);
|
||||
}
|
||||
{
|
||||
let rma = &mut u.a;
|
||||
u.b = 1; //[ast]~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
//[mir]~^ ERROR cannot assign to `u.b` because it is borrowed
|
||||
u.b = 1; //~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
drop(rma);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,115 +1,115 @@
|
|||
error[E0502]: cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
--> $DIR/borrowck-union-borrow.rs:27:28
|
||||
--> $DIR/borrowck-union-borrow.rs:25:28
|
||||
|
|
||||
LL | let ra = &u.a;
|
||||
| --- immutable borrow occurs here
|
||||
LL | let rma = &mut u.a; //[ast]~ ERROR cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
LL | let rma = &mut u.a; //~ ERROR cannot borrow `u.a` as mutable because it is also borrowed as immutable
|
||||
| ^^^ mutable borrow occurs here
|
||||
...
|
||||
LL | drop(ra);
|
||||
LL | }
|
||||
| - immutable borrow ends here
|
||||
|
||||
error[E0506]: cannot assign to `u.a` because it is borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:33:13
|
||||
--> $DIR/borrowck-union-borrow.rs:30:13
|
||||
|
|
||||
LL | let ra = &u.a;
|
||||
| --- borrow of `u.a` occurs here
|
||||
LL | u.a = 1; //[ast]~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
LL | u.a = 1; //~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
| ^^^^^^^ assignment to borrowed `u.a` occurs here
|
||||
|
||||
error[E0502]: cannot borrow `u` (via `u.b`) as mutable because `u` is also borrowed as immutable (via `u.a`)
|
||||
--> $DIR/borrowck-union-borrow.rs:50:28
|
||||
--> $DIR/borrowck-union-borrow.rs:46:28
|
||||
|
|
||||
LL | let ra = &u.a;
|
||||
| --- immutable borrow occurs here (via `u.a`)
|
||||
LL | let rmb = &mut u.b; //[ast]~ ERROR cannot borrow `u` (via `u.b`) as mutable because `u` is also borrowed as immutable (via `u.a`)
|
||||
| ^^^ mutable borrow occurs here (via `u.b`)
|
||||
...
|
||||
LL | let rmb = &mut u.b; //~ ERROR cannot borrow `u` (via `u.b`) as mutable because `u` is also borrowed as immutable (via `u.a`)
|
||||
| ^^^ mutable borrow of `u.b` -- which overlaps with `u.a` -- occurs here
|
||||
LL | drop(ra);
|
||||
LL | }
|
||||
| - immutable borrow ends here
|
||||
|
||||
error[E0506]: cannot assign to `u.b` because it is borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:56:13
|
||||
--> $DIR/borrowck-union-borrow.rs:51:13
|
||||
|
|
||||
LL | let ra = &u.a;
|
||||
| --- borrow of `u.b` occurs here
|
||||
LL | u.b = 1; //[ast]~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
LL | u.b = 1; //~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
| ^^^^^^^ assignment to borrowed `u.b` occurs here
|
||||
|
||||
error[E0502]: cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
--> $DIR/borrowck-union-borrow.rs:63:23
|
||||
--> $DIR/borrowck-union-borrow.rs:57:23
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| --- mutable borrow occurs here
|
||||
LL | let ra = &u.a; //[ast]~ ERROR cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
LL | let ra = &u.a; //~ ERROR cannot borrow `u.a` as immutable because it is also borrowed as mutable
|
||||
| ^^^ immutable borrow occurs here
|
||||
...
|
||||
LL | drop(rma);
|
||||
LL | }
|
||||
| - mutable borrow ends here
|
||||
|
||||
error[E0503]: cannot use `u.a` because it was mutably borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:69:17
|
||||
--> $DIR/borrowck-union-borrow.rs:62:17
|
||||
|
|
||||
LL | let ra = &mut u.a;
|
||||
| --- borrow of `u.a` occurs here
|
||||
LL | let a = u.a; //[ast]~ ERROR cannot use `u.a` because it was mutably borrowed
|
||||
LL | let a = u.a; //~ ERROR cannot use `u.a` because it was mutably borrowed
|
||||
| ^ use of borrowed `u.a`
|
||||
|
||||
error[E0499]: cannot borrow `u.a` as mutable more than once at a time
|
||||
--> $DIR/borrowck-union-borrow.rs:75:29
|
||||
--> $DIR/borrowck-union-borrow.rs:67:29
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| --- first mutable borrow occurs here
|
||||
LL | let rma2 = &mut u.a; //[ast]~ ERROR cannot borrow `u.a` as mutable more than once at a time
|
||||
LL | let rma2 = &mut u.a; //~ ERROR cannot borrow `u.a` as mutable more than once at a time
|
||||
| ^^^ second mutable borrow occurs here
|
||||
...
|
||||
LL | drop(rma);
|
||||
LL | }
|
||||
| - first borrow ends here
|
||||
|
||||
error[E0506]: cannot assign to `u.a` because it is borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:81:13
|
||||
--> $DIR/borrowck-union-borrow.rs:72:13
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| --- borrow of `u.a` occurs here
|
||||
LL | u.a = 1; //[ast]~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
LL | u.a = 1; //~ ERROR cannot assign to `u.a` because it is borrowed
|
||||
| ^^^^^^^ assignment to borrowed `u.a` occurs here
|
||||
|
||||
error[E0502]: cannot borrow `u` (via `u.b`) as immutable because `u` is also borrowed as mutable (via `u.a`)
|
||||
--> $DIR/borrowck-union-borrow.rs:88:23
|
||||
--> $DIR/borrowck-union-borrow.rs:78:23
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| --- mutable borrow occurs here (via `u.a`)
|
||||
LL | let rb = &u.b; //[ast]~ ERROR cannot borrow `u` (via `u.b`) as immutable because `u` is also borrowed as mutable (via `u.a`)
|
||||
| ^^^ immutable borrow occurs here (via `u.b`)
|
||||
...
|
||||
LL | let rb = &u.b; //~ ERROR cannot borrow `u` (via `u.b`) as immutable because `u` is also borrowed as mutable (via `u.a`)
|
||||
| ^^^ immutable borrow of `u.b` -- which overlaps with `u.a` -- occurs here
|
||||
LL | drop(rma);
|
||||
LL | }
|
||||
| - mutable borrow ends here
|
||||
|
||||
error[E0503]: cannot use `u.b` because it was mutably borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:94:17
|
||||
--> $DIR/borrowck-union-borrow.rs:83:17
|
||||
|
|
||||
LL | let ra = &mut u.a;
|
||||
| --- borrow of `u.a` occurs here
|
||||
LL | let b = u.b; //[ast]~ ERROR cannot use `u.b` because it was mutably borrowed
|
||||
LL | let b = u.b; //~ ERROR cannot use `u.b` because it was mutably borrowed
|
||||
| ^ use of borrowed `u.a`
|
||||
|
||||
error[E0499]: cannot borrow `u` (via `u.b`) as mutable more than once at a time
|
||||
--> $DIR/borrowck-union-borrow.rs:101:29
|
||||
--> $DIR/borrowck-union-borrow.rs:89:29
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| --- first mutable borrow occurs here (via `u.a`)
|
||||
LL | let rmb2 = &mut u.b; //[ast]~ ERROR cannot borrow `u` (via `u.b`) as mutable more than once at a time
|
||||
LL | let rmb2 = &mut u.b; //~ ERROR cannot borrow `u` (via `u.b`) as mutable more than once at a time
|
||||
| ^^^ second mutable borrow occurs here (via `u.b`)
|
||||
...
|
||||
LL | drop(rma);
|
||||
LL | }
|
||||
| - first borrow ends here
|
||||
|
||||
error[E0506]: cannot assign to `u.b` because it is borrowed
|
||||
--> $DIR/borrowck-union-borrow.rs:107:13
|
||||
--> $DIR/borrowck-union-borrow.rs:94:13
|
||||
|
|
||||
LL | let rma = &mut u.a;
|
||||
| --- borrow of `u.b` occurs here
|
||||
LL | u.b = 1; //[ast]~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
LL | u.b = 1; //~ ERROR cannot assign to `u.b` because it is borrowed
|
||||
| ^^^^^^^ assignment to borrowed `u.b` occurs here
|
||||
|
||||
error: aborting due to 12 previous errors
|
||||
|
|
@ -13,7 +13,7 @@ error[E0502]: cannot borrow `foo` (via `foo.b`) as immutable because `foo` is al
|
|||
--> $DIR/issue-17263.rs:21:32
|
||||
|
|
||||
LL | let (c, d) = (&mut foo.a, &foo.b);
|
||||
| ----- ^^^^^ immutable borrow occurs here (via `foo.b`)
|
||||
| ----- ^^^^^ immutable borrow of `foo.b` -- which overlaps with `foo.a` -- occurs here
|
||||
| |
|
||||
| mutable borrow occurs here (via `foo.a`)
|
||||
...
|
||||
|
|
|
|||
|
|
@ -1,6 +1,8 @@
|
|||
#![allow(unused)]
|
||||
#![feature(nll)]
|
||||
|
||||
// ignore-tidy-linelength
|
||||
|
||||
#[derive(Clone, Copy, Default)]
|
||||
struct S {
|
||||
a: u8,
|
||||
|
|
@ -25,8 +27,7 @@ fn main() {
|
|||
*mref = 22;
|
||||
|
||||
let nref = &u.z.c;
|
||||
//~^ ERROR cannot borrow `u.z.c` as immutable because it is also borrowed as mutable [E0502]
|
||||
//~^ ERROR cannot borrow `u` (via `u.z.c`) as immutable because it is also borrowed as mutable (via `u.s.a`) [E0502]
|
||||
println!("{} {}", mref, nref)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -1,14 +1,16 @@
|
|||
error[E0502]: cannot borrow `u.z.c` as immutable because it is also borrowed as mutable
|
||||
--> $DIR/issue-45157.rs:27:20
|
||||
error[E0502]: cannot borrow `u` (via `u.z.c`) as immutable because it is also borrowed as mutable (via `u.s.a`)
|
||||
--> $DIR/issue-45157.rs:29:20
|
||||
|
|
||||
LL | let mref = &mut u.s.a;
|
||||
| ---------- mutable borrow occurs here
|
||||
| ---------- mutable borrow occurs here (via `u.s.a`)
|
||||
...
|
||||
LL | let nref = &u.z.c;
|
||||
| ^^^^^^ immutable borrow occurs here
|
||||
LL | //~^ ERROR cannot borrow `u.z.c` as immutable because it is also borrowed as mutable [E0502]
|
||||
| ^^^^^^ immutable borrow of `u.z.c` -- which overlaps with `u.s.a` -- occurs here
|
||||
LL | //~^ ERROR cannot borrow `u` (via `u.z.c`) as immutable because it is also borrowed as mutable (via `u.s.a`) [E0502]
|
||||
LL | println!("{} {}", mref, nref)
|
||||
| ---- mutable borrow later used here
|
||||
|
|
||||
= note: `u.z.c` is a field of the union `U`, so it overlaps the field `u.s.a`
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
|
|
|
|||
69
src/test/ui/nll/issue-57100.rs
Normal file
69
src/test/ui/nll/issue-57100.rs
Normal file
|
|
@ -0,0 +1,69 @@
|
|||
#![allow(unused)]
|
||||
#![feature(nll)]
|
||||
|
||||
// ignore-tidy-linelength
|
||||
|
||||
// This tests the error messages for borrows of union fields when the unions are embedded in other
|
||||
// structs or unions.
|
||||
|
||||
#[derive(Clone, Copy, Default)]
|
||||
struct Leaf {
|
||||
l1_u8: u8,
|
||||
l2_u8: u8,
|
||||
}
|
||||
|
||||
#[derive(Clone, Copy)]
|
||||
union First {
|
||||
f1_leaf: Leaf,
|
||||
f2_leaf: Leaf,
|
||||
f3_union: Second,
|
||||
}
|
||||
|
||||
#[derive(Clone, Copy)]
|
||||
union Second {
|
||||
s1_leaf: Leaf,
|
||||
s2_leaf: Leaf,
|
||||
}
|
||||
|
||||
struct Root {
|
||||
r1_u8: u8,
|
||||
r2_union: First,
|
||||
}
|
||||
|
||||
// Borrow a different field of the nested union.
|
||||
fn nested_union() {
|
||||
unsafe {
|
||||
let mut r = Root {
|
||||
r1_u8: 3,
|
||||
r2_union: First { f3_union: Second { s2_leaf: Leaf { l1_u8: 8, l2_u8: 4 } } }
|
||||
};
|
||||
|
||||
let mref = &mut r.r2_union.f3_union.s1_leaf.l1_u8;
|
||||
// ^^^^^^^
|
||||
*mref = 22;
|
||||
let nref = &r.r2_union.f3_union.s2_leaf.l1_u8;
|
||||
// ^^^^^^^
|
||||
//~^^ ERROR cannot borrow `r.r2_union.f3_union` (via `r.r2_union.f3_union.s2_leaf.l1_u8`) as immutable because it is also borrowed as mutable (via `r.r2_union.f3_union.s1_leaf.l1_u8`) [E0502]
|
||||
println!("{} {}", mref, nref)
|
||||
}
|
||||
}
|
||||
|
||||
// Borrow a different field of the first union.
|
||||
fn first_union() {
|
||||
unsafe {
|
||||
let mut r = Root {
|
||||
r1_u8: 3,
|
||||
r2_union: First { f3_union: Second { s2_leaf: Leaf { l1_u8: 8, l2_u8: 4 } } }
|
||||
};
|
||||
|
||||
let mref = &mut r.r2_union.f2_leaf.l1_u8;
|
||||
// ^^^^^^^
|
||||
*mref = 22;
|
||||
let nref = &r.r2_union.f1_leaf.l1_u8;
|
||||
// ^^^^^^^
|
||||
//~^^ ERROR cannot borrow `r.r2_union` (via `r.r2_union.f1_leaf.l1_u8`) as immutable because it is also borrowed as mutable (via `r.r2_union.f2_leaf.l1_u8`) [E0502]
|
||||
println!("{} {}", mref, nref)
|
||||
}
|
||||
}
|
||||
|
||||
fn main() {}
|
||||
31
src/test/ui/nll/issue-57100.stderr
Normal file
31
src/test/ui/nll/issue-57100.stderr
Normal file
|
|
@ -0,0 +1,31 @@
|
|||
error[E0502]: cannot borrow `r.r2_union.f3_union` (via `r.r2_union.f3_union.s2_leaf.l1_u8`) as immutable because it is also borrowed as mutable (via `r.r2_union.f3_union.s1_leaf.l1_u8`)
|
||||
--> $DIR/issue-57100.rs:44:20
|
||||
|
|
||||
LL | let mref = &mut r.r2_union.f3_union.s1_leaf.l1_u8;
|
||||
| -------------------------------------- mutable borrow occurs here (via `r.r2_union.f3_union.s1_leaf.l1_u8`)
|
||||
...
|
||||
LL | let nref = &r.r2_union.f3_union.s2_leaf.l1_u8;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ immutable borrow of `r.r2_union.f3_union.s2_leaf.l1_u8` -- which overlaps with `r.r2_union.f3_union.s1_leaf.l1_u8` -- occurs here
|
||||
...
|
||||
LL | println!("{} {}", mref, nref)
|
||||
| ---- mutable borrow later used here
|
||||
|
|
||||
= note: `r.r2_union.f3_union.s2_leaf.l1_u8` is a field of the union `Second`, so it overlaps the field `r.r2_union.f3_union.s1_leaf.l1_u8`
|
||||
|
||||
error[E0502]: cannot borrow `r.r2_union` (via `r.r2_union.f1_leaf.l1_u8`) as immutable because it is also borrowed as mutable (via `r.r2_union.f2_leaf.l1_u8`)
|
||||
--> $DIR/issue-57100.rs:62:20
|
||||
|
|
||||
LL | let mref = &mut r.r2_union.f2_leaf.l1_u8;
|
||||
| ----------------------------- mutable borrow occurs here (via `r.r2_union.f2_leaf.l1_u8`)
|
||||
...
|
||||
LL | let nref = &r.r2_union.f1_leaf.l1_u8;
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^ immutable borrow of `r.r2_union.f1_leaf.l1_u8` -- which overlaps with `r.r2_union.f2_leaf.l1_u8` -- occurs here
|
||||
...
|
||||
LL | println!("{} {}", mref, nref)
|
||||
| ---- mutable borrow later used here
|
||||
|
|
||||
= note: `r.r2_union.f1_leaf.l1_u8` is a field of the union `First`, so it overlaps the field `r.r2_union.f2_leaf.l1_u8`
|
||||
|
||||
error: aborting due to 2 previous errors
|
||||
|
||||
For more information about this error, try `rustc --explain E0502`.
|
||||
|
|
@ -28,7 +28,7 @@ fn foo<T>(iter: T) where T: StreamingIterator, for<'a> T::Item<'a>: Display { /*
|
|||
|
||||
// Full example of enumerate iterator
|
||||
|
||||
#[must_use = "iterator adaptors are lazy and do nothing unless consumed"]
|
||||
#[must_use = "iterators are lazy and do nothing unless consumed"]
|
||||
struct StreamEnumerate<I> {
|
||||
iter: I,
|
||||
count: usize,
|
||||
|
|
|
|||
|
|
@ -1,12 +1,14 @@
|
|||
error[E0502]: cannot borrow `u.y` as immutable because it is also borrowed as mutable
|
||||
error[E0502]: cannot borrow `u` (via `u.y`) as immutable because it is also borrowed as mutable (via `u.x.0`)
|
||||
--> $DIR/union-borrow-move-parent-sibling.rs:15:13
|
||||
|
|
||||
LL | let a = &mut u.x.0;
|
||||
| ---------- mutable borrow occurs here
|
||||
| ---------- mutable borrow occurs here (via `u.x.0`)
|
||||
LL | let b = &u.y; //~ ERROR cannot borrow `u.y`
|
||||
| ^^^^ immutable borrow occurs here
|
||||
| ^^^^ immutable borrow of `u.y` -- which overlaps with `u.x.0` -- occurs here
|
||||
LL | use_borrow(a);
|
||||
| - mutable borrow later used here
|
||||
|
|
||||
= note: `u.y` is a field of the union `U`, so it overlaps the field `u.x.0`
|
||||
|
||||
error[E0382]: use of moved value: `u`
|
||||
--> $DIR/union-borrow-move-parent-sibling.rs:22:13
|
||||
|
|
@ -18,15 +20,17 @@ LL | let b = u.y; //~ ERROR use of moved value: `u.y`
|
|||
|
|
||||
= note: move occurs because `u` has type `U`, which does not implement the `Copy` trait
|
||||
|
||||
error[E0502]: cannot borrow `u.y` as immutable because it is also borrowed as mutable
|
||||
error[E0502]: cannot borrow `u` (via `u.y`) as immutable because it is also borrowed as mutable (via `u.x.0.0`)
|
||||
--> $DIR/union-borrow-move-parent-sibling.rs:28:13
|
||||
|
|
||||
LL | let a = &mut (u.x.0).0;
|
||||
| -------------- mutable borrow occurs here
|
||||
| -------------- mutable borrow occurs here (via `u.x.0.0`)
|
||||
LL | let b = &u.y; //~ ERROR cannot borrow `u.y`
|
||||
| ^^^^ immutable borrow occurs here
|
||||
| ^^^^ immutable borrow of `u.y` -- which overlaps with `u.x.0.0` -- occurs here
|
||||
LL | use_borrow(a);
|
||||
| - mutable borrow later used here
|
||||
|
|
||||
= note: `u.y` is a field of the union `U`, so it overlaps the field `u.x.0.0`
|
||||
|
||||
error[E0382]: use of moved value: `u`
|
||||
--> $DIR/union-borrow-move-parent-sibling.rs:35:13
|
||||
|
|
@ -38,15 +42,17 @@ LL | let b = u.y; //~ ERROR use of moved value: `u.y`
|
|||
|
|
||||
= note: move occurs because `u` has type `U`, which does not implement the `Copy` trait
|
||||
|
||||
error[E0502]: cannot borrow `u.x` as immutable because it is also borrowed as mutable
|
||||
error[E0502]: cannot borrow `u` (via `u.x`) as immutable because it is also borrowed as mutable (via `*u.y`)
|
||||
--> $DIR/union-borrow-move-parent-sibling.rs:41:13
|
||||
|
|
||||
LL | let a = &mut *u.y;
|
||||
| --------- mutable borrow occurs here
|
||||
| --------- mutable borrow occurs here (via `*u.y`)
|
||||
LL | let b = &u.x; //~ ERROR cannot borrow `u` (via `u.x`)
|
||||
| ^^^^ immutable borrow occurs here
|
||||
| ^^^^ immutable borrow of `u.x` -- which overlaps with `*u.y` -- occurs here
|
||||
LL | use_borrow(a);
|
||||
| - mutable borrow later used here
|
||||
|
|
||||
= note: `u.x` is a field of the union `U`, so it overlaps the field `*u.y`
|
||||
|
||||
error[E0382]: use of moved value: `u`
|
||||
--> $DIR/union-borrow-move-parent-sibling.rs:48:13
|
||||
|
|
|
|||
|
|
@ -46,7 +46,7 @@ error[E0502]: cannot borrow `u` (via `u.x`) as immutable because `u` is also bor
|
|||
LL | let a = &mut *u.y;
|
||||
| ---- mutable borrow occurs here (via `*u.y`)
|
||||
LL | let b = &u.x; //~ ERROR cannot borrow `u` (via `u.x`)
|
||||
| ^^^ immutable borrow occurs here (via `u.x`)
|
||||
| ^^^ immutable borrow of `u.x` -- which overlaps with `*u.y` -- occurs here
|
||||
LL | use_borrow(a);
|
||||
LL | }
|
||||
| - mutable borrow ends here
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue