From 2f6e59d94126bf9d4d09fe92b18d329a1631448f Mon Sep 17 00:00:00 2001 From: Aaron Hill Date: Mon, 19 Oct 2020 11:54:09 -0400 Subject: [PATCH] Don't display empty future-compat report --- src/tools/compiletest/src/json.rs | 37 ++++++++++++++++++------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/src/tools/compiletest/src/json.rs b/src/tools/compiletest/src/json.rs index 176c3219307c..19aec0ea598f 100644 --- a/src/tools/compiletest/src/json.rs +++ b/src/tools/compiletest/src/json.rs @@ -94,22 +94,27 @@ pub fn extract_rendered(output: &str) -> String { if let Ok(diagnostic) = serde_json::from_str::(line) { diagnostic.rendered } else if let Ok(report) = serde_json::from_str::(line) { - Some(format!( - "Future incompatibility report: {}", - report - .future_incompat_report - .into_iter() - .map(|item| { - format!( - "Future breakage date: {}, diagnostic:\n{}", - item.future_breakage_date.unwrap_or_else(|| "None".to_string()), - item.diagnostic - .rendered - .unwrap_or_else(|| "Not rendered".to_string()) - ) - }) - .collect::() - )) + if report.future_incompat_report.is_empty() { + None + } else { + Some(format!( + "Future incompatibility report: {}", + report + .future_incompat_report + .into_iter() + .map(|item| { + format!( + "Future breakage date: {}, diagnostic:\n{}", + item.future_breakage_date + .unwrap_or_else(|| "None".to_string()), + item.diagnostic + .rendered + .unwrap_or_else(|| "Not rendered".to_string()) + ) + }) + .collect::() + )) + } } else if serde_json::from_str::(line).is_ok() { // Ignore the notification. None