user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #2147 from clippered/fix-manual-memcpy-on-overlapping-slices

Browse source 
Fix #2123 : check that the source and destination are different for m…
This commit is contained in:
Oliver Schneider 2017-10-20 09:27:15 +02:00 • committed by GitHub
commit 327d995bb6
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
clippy_lints/src/loops.rs
View file

@ -749,7 +749,14 @@ fn get_indexed_assignments<'a, 'tcx>(
) -> Option<(FixedOffsetVar, FixedOffsetVar)> {
if let Expr_::ExprAssign(ref lhs, ref rhs) = e.node {
match (get_fixed_offset_var(cx, lhs, var), fetch_cloned_fixed_offset_var(cx, rhs, var)) {
(Some(offset_left), Some(offset_right)) => Some((offset_left, offset_right)),
(Some(offset_left), Some(offset_right)) => {
// Source and destination must be different
if offset_left.var_name != offset_right.var_name {
Some((offset_left, offset_right))
} else {
None
}
},
_ => None,
}
} else {