user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Lint items after statements in macro expansions

Browse source 
The items_after_statements lint was skipping all expansions.  Instead
we should still lint local macros.

Fixes #578
This commit is contained in:
Chris Ayoup 2020-10-14 23:49:48 -04:00
parent 0cba5e6bd3
commit 32e2021b75
3 changed files with 22 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tests/ui/item_after_statement.rs
View file

@ -28,7 +28,10 @@ fn mac() {
// do not lint this, because it needs to be after `a`
macro_rules! b {
() => {{
a = 6
a = 6;
fn say_something() {
println!("something");
}
}};
}
b!();

15
tests/ui/item_after_statement.stderr
View file

@ -16,5 +16,18 @@ LL | | println!("foo");
LL | | }
| |_____^
error: aborting due to 2 previous errors
error: adding items after statements is confusing, since items exist from the start of the scope
--> $DIR/item_after_statement.rs:32:13
|
LL | / fn say_something() {
LL | | println!("something");
LL | | }
| |_____________^
...
LL | b!();
| ----- in this macro invocation
|
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: aborting due to 3 previous errors