user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove the FIXME about the cache size checks

Browse source 
And leave a NOTE.
This commit is contained in:
Luca Barbato 2019-09-17 17:02:45 +02:00
parent 6420fa4fb0
commit 33688eaa10
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
library/stdarch/crates/std_detect/src/detect/cache.rs
View file

@ -43,13 +43,13 @@ impl Default for Initializer {
}
}
// NOTE: the `debug_assert!` would catch that we do not add more Features than
// the one fitting our cache.
impl Initializer {
/// Tests the `bit` of the cache.
#[allow(dead_code)]
#[inline]
pub(crate) fn test(self, bit: u32) -> bool {
// FIXME: this way of making sure that the cache is large enough is
// brittle.
debug_assert!(
bit < CACHE_CAPACITY,
"too many features, time to increase the cache size!"
@ -60,8 +60,6 @@ impl Initializer {
/// Sets the `bit` of the cache.
#[inline]
pub(crate) fn set(&mut self, bit: u32) {
// FIXME: this way of making sure that the cache is large enough is
// brittle.
debug_assert!(
bit < CACHE_CAPACITY,
"too many features, time to increase the cache size!"
@ -73,8 +71,6 @@ impl Initializer {
/// Unsets the `bit` of the cache.
#[inline]
pub(crate) fn unset(&mut self, bit: u32) {
// FIXME: this way of making sure that the cache is large enough is
// brittle.
debug_assert!(
bit < CACHE_CAPACITY,
"too many features, time to increase the cache size!"