Rollup merge of #69384 - petrochenkov:nounnorm, r=Centril
parser: `token` -> `normalized_token`, `nonnormalized_token` -> `token` So, after https://github.com/rust-lang/rust/pull/69006, its follow-ups and an attempt to remove `Parser::prev_span` I came to the conclusion that the unnormalized token and its span is what you want in most cases, so it should be default. Normalization only makes difference in few cases where we are checking against `token::Ident` or `token::Lifetime` specifically. This PR uses `normalized_token` for those cases. Using normalization explicitly means that people writing code should remember about `NtIdent` and `NtLifetime` in general. (That is alleviated by the fact that `token.ident()` and `fn parse_ident_*` are already written.) Remembering about `NtIdent`, was, however, already the case, kind of, because the implicit normalization was performed only for the current/previous token, but not for things like `look_ahead`. As a result, most of token classification methods in `token.rs` already take `NtIdent` into account (this PR fixes a few pre-existing minor mistakes though). The next step is removing `normalized(_prev)_token` entirely and replacing it with `token.ident()` (mostly) and `token.normalize()` (occasionally). I want to make it a separate PR for that and run it though perf. `normalized_token` filled on every bump has both a potential to avoid repeated normalization, and to do unnecessary work in advance (it probably doesn't matter anyway, the normalization is very cheap). r? @Centril
This commit is contained in:
commit
3828fa2852
16 changed files with 132 additions and 125 deletions
|
|
@ -1,14 +1,16 @@
|
|||
error[E0507]: cannot move out of static item `D`
|
||||
--> $DIR/move-error-snippets.rs:16:18
|
||||
--> $DIR/move-error-snippets-ext.rs:5:17
|
||||
|
|
||||
LL | | #[macro_use]
|
||||
| |__________________^ move occurs because `D` has type `A`, which does not implement the `Copy` trait
|
||||
...
|
||||
LL | aaa!(D);
|
||||
| __________________^
|
||||
...
|
||||
LL | sss!();
|
||||
| ------- in this macro invocation
|
||||
LL | let a = $c;
|
||||
| ^^
|
||||
| |
|
||||
| move occurs because `D` has type `A`, which does not implement the `Copy` trait
|
||||
| help: consider borrowing here: `&$c`
|
||||
|
|
||||
::: $DIR/move-error-snippets.rs:21:1
|
||||
|
|
||||
LL | sss!();
|
||||
| ------- in this macro invocation
|
||||
|
|
||||
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
|
||||
|
||||
|
|
|
|||
|
|
@ -1,7 +1,7 @@
|
|||
// Test that macro-expanded non-inline modules behave correctly
|
||||
|
||||
macro_rules! mod_decl {
|
||||
($i:ident) => { mod $i; }
|
||||
($i:ident) => { mod $i; } //~ ERROR Cannot declare a non-inline module inside a block
|
||||
}
|
||||
|
||||
mod macro_expanded_mod_helper {
|
||||
|
|
@ -10,5 +10,4 @@ mod macro_expanded_mod_helper {
|
|||
|
||||
fn main() {
|
||||
mod_decl!(foo);
|
||||
//~^ ERROR Cannot declare a non-inline module inside a block
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,8 +1,13 @@
|
|||
error: Cannot declare a non-inline module inside a block unless it has a path attribute
|
||||
--> $DIR/macro-expanded-mod.rs:12:15
|
||||
--> $DIR/macro-expanded-mod.rs:4:25
|
||||
|
|
||||
LL | ($i:ident) => { mod $i; }
|
||||
| ^^
|
||||
...
|
||||
LL | mod_decl!(foo);
|
||||
| ^^^
|
||||
| --------------- in this macro invocation
|
||||
|
|
||||
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
|
|
|
|||
|
|
@ -1,10 +1,10 @@
|
|||
error[E0124]: field `a` is already declared
|
||||
--> $DIR/fields-definition.rs:14:17
|
||||
--> $DIR/fields-definition.rs:14:13
|
||||
|
|
||||
LL | a: u8,
|
||||
| ----- `a` first declared here
|
||||
LL | $a: u8,
|
||||
| ^^ field already declared
|
||||
| ^^^^^^ field already declared
|
||||
...
|
||||
LL | legacy!(a);
|
||||
| ----------- in this macro invocation
|
||||
|
|
|
|||
|
|
@ -1,10 +1,9 @@
|
|||
macro_rules! get_opt {
|
||||
($tgt:expr, $field:ident) => {
|
||||
if $tgt.has_$field() {}
|
||||
if $tgt.has_$field() {} //~ ERROR expected `{`, found `foo`
|
||||
}
|
||||
}
|
||||
|
||||
fn main() {
|
||||
get_opt!(bar, foo);
|
||||
//~^ ERROR expected `{`, found `foo`
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,13 +1,17 @@
|
|||
error: expected `{`, found `foo`
|
||||
--> $DIR/issue-39848.rs:8:19
|
||||
--> $DIR/issue-39848.rs:3:21
|
||||
|
|
||||
LL | if $tgt.has_$field() {}
|
||||
| -- -- help: try placing this code inside a block: `{ () }`
|
||||
| |
|
||||
| -- ^^^^^^--
|
||||
| | |
|
||||
| | expected `{`
|
||||
| | help: try placing this code inside a block: `{ $field() }`
|
||||
| this `if` expression has a condition, but no block
|
||||
...
|
||||
LL | get_opt!(bar, foo);
|
||||
| ^^^ expected `{`
|
||||
| ------------------- in this macro invocation
|
||||
|
|
||||
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue