user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(rc_buffer): remove RcKind

Browse source 
not really necessary
This commit is contained in:
Ada Alakbarova 2025-11-14 12:03:05 +01:00
parent 663ef9b31b
commit 3bef3ff3d4
No known key found for this signature in database
1 changed files with 4 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

23
clippy_lints/src/types/rc_buffer.rs
View file

@ -8,15 +8,14 @@ use rustc_hir::{QPath, Ty, TyKind};
use rustc_lint::LateContext;
use rustc_span::symbol::sym;
use std::borrow::Cow;
use std::fmt;
use super::RC_BUFFER;
pub(super) fn check(cx: &LateContext<'_>, hir_ty: &Ty<'_>, qpath: &QPath<'_>, def_id: DefId) -> bool {
let mut app = Applicability::Unspecified;
let kind = match cx.tcx.get_diagnostic_name(def_id) {
Some(sym::Rc) => RcKind::Rc,
Some(sym::Arc) => RcKind::Arc,
let rc = match cx.tcx.get_diagnostic_name(def_id) {
Some(sym::Rc) => "Rc",
Some(sym::Arc) => "Arc",
_ => return false,
};
if let Some(ty) = qpath_generic_tys(qpath).next()
@ -26,7 +25,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &Ty<'_>, qpath: &QPath<'_>, de
cx,
RC_BUFFER,
hir_ty.span,
format!("usage of `{kind}<T>` when `T` is a buffer type"),
format!("usage of `{rc}<T>` when `T` is a buffer type"),
|diag| {
diag.span_suggestion_verbose(ty.span, "try", alternate, app);
},
@ -37,20 +36,6 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &Ty<'_>, qpath: &QPath<'_>, de
}
}
enum RcKind {
Rc,
Arc,
}
impl fmt::Display for RcKind {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Self::Rc => f.write_str("Rc"),
Self::Arc => f.write_str("Arc"),
}
}
}
fn match_buffer_type(
cx: &LateContext<'_>,
ty: &Ty<'_>,