Auto merge of #75260 - davidtwco:polymorphization-promoted-substs, r=lcnr

polymorphize: unevaluated constants

This PR makes polymorphization visit the promoted MIR of unevaluated constants with available promoted MIR instead of visiting the substitutions of that constant - which will mark all of the generic parameters as used; in addition polymorphization will now visit non-promoted unevaluated constants rather than visit their substs.

r? @lcnr
This commit is contained in:
bors 2020-08-08 15:57:12 +00:00
commit 3f091baba4
8 changed files with 104 additions and 15 deletions

View file

@ -0,0 +1,12 @@
// build-fail
// compile-flags: -Zpolymorphize=on
#![crate_type = "lib"]
#![feature(rustc_attrs)]
fn foo<'a>(_: &'a ()) {}
#[rustc_polymorphize_error]
pub fn test<T>() {
//~^ ERROR item has unused generic parameters
foo(&());
}

View file

@ -0,0 +1,8 @@
error: item has unused generic parameters
--> $DIR/promoted-function-1.rs:9:8
|
LL | pub fn test<T>() {
| ^^^^ - generic parameter `T` is unused
error: aborting due to previous error

View file

@ -0,0 +1,16 @@
// build-fail
// compile-flags:-Zpolymorphize=on
#![crate_type = "lib"]
#![feature(lazy_normalization_consts, rustc_attrs)]
//~^ WARN the feature `lazy_normalization_consts` is incomplete
#[rustc_polymorphize_error]
fn test<T>() {
//~^ ERROR item has unused generic parameters
let x = [0; 3 + 4];
}
pub fn caller() {
test::<String>();
test::<Vec<String>>();
}

View file

@ -0,0 +1,17 @@
warning: the feature `lazy_normalization_consts` is incomplete and may not be safe to use and/or cause compiler crashes
--> $DIR/promoted-function-2.rs:4:12
|
LL | #![feature(lazy_normalization_consts, rustc_attrs)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(incomplete_features)]` on by default
= note: see issue #72219 <https://github.com/rust-lang/rust/issues/72219> for more information
error: item has unused generic parameters
--> $DIR/promoted-function-2.rs:8:4
|
LL | fn test<T>() {
| ^^^^ - generic parameter `T` is unused
error: aborting due to previous error; 1 warning emitted

View file

@ -1,4 +1,6 @@
// run-pass
// compile-flags:-Zpolymorphize=on
fn fop<T>() {}
fn bar<T>() -> &'static fn() {

View file

@ -17,6 +17,7 @@ fn foo<T: Default>() {
fn foo2<T: Default>() {
let _: T = Default::default();
(|| {
//~^ ERROR item has unused generic parameters
let call: extern "rust-call" fn(_, _) = Fn::call;
call(&|| {}, ());
//~^ ERROR item has unused generic parameters

View file

@ -17,7 +17,7 @@ LL | (|| Box::new(|| {}) as Box<dyn Fn()>)();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: item has unused generic parameters
--> $DIR/unsized_cast.rs:21:15
--> $DIR/unsized_cast.rs:22:15
|
LL | fn foo2<T: Default>() {
| - generic parameter `T` is unused
@ -25,5 +25,19 @@ LL | fn foo2<T: Default>() {
LL | call(&|| {}, ());
| ^^^^^
error: aborting due to 3 previous errors
error: item has unused generic parameters
--> $DIR/unsized_cast.rs:19:5
|
LL | fn foo2<T: Default>() {
| - generic parameter `T` is unused
LL | let _: T = Default::default();
LL | / (|| {
LL | |
LL | | let call: extern "rust-call" fn(_, _) = Fn::call;
LL | | call(&|| {}, ());
LL | |
LL | | })();
| |______^
error: aborting due to 4 previous errors