user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

don't unnecessarily walk more in visitor and add more tests

Browse source
This commit is contained in:
y21 2023-06-15 22:04:25 +02:00
parent e305b0730f
commit 3fe2478ecf
4 changed files with 30 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
clippy_lints/src/redundant_closure_call.rs
View file

@ -55,9 +55,9 @@ impl<'tcx> Visitor<'tcx> for ReturnVisitor {
fn visit_expr(&mut self, ex: &'tcx hir::Expr<'tcx>) {
if let hir::ExprKind::Ret(_) | hir::ExprKind::Match(.., hir::MatchSource::TryDesugar) = ex.kind {
self.found_return = true;
} else {
hir_visit::walk_expr(self, ex);
}
hir_visit::walk_expr(self, ex);
}
}
@ -122,7 +122,7 @@ fn get_parent_call_exprs<'tcx>(
let mut depth = 1;
while let Some(parent) = get_parent_expr(cx, expr)
&& let hir::ExprKind::Call(recv, _) = parent.kind
&& let hir::ExprKind::Call(..) = recv.kind
&& expr.span == recv.span
{
expr = parent;
depth += 1;