From 410f71fcc30bf6dbff4cba2c87633dc9450553b7 Mon Sep 17 00:00:00 2001 From: Josh McKinney Date: Wed, 24 Apr 2024 01:29:31 -0700 Subject: [PATCH] fix: move no_std check out of loop --- .../rust-analyzer/crates/rust-analyzer/src/handlers/request.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/request.rs b/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/request.rs index c5796ac07144..004e69dd32dc 100644 --- a/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/request.rs +++ b/src/tools/rust-analyzer/crates/rust-analyzer/src/handlers/request.rs @@ -836,13 +836,14 @@ pub(crate) fn handle_runnables( let config = snap.config.runnables(); match cargo_spec { Some(spec) => { + let is_crate_no_std = snap.analysis.is_crate_no_std(spec.crate_id)?; for cmd in ["check", "run", "test"] { if cmd == "run" && spec.target_kind != TargetKind::Bin { continue; } let mut cargo_args = vec![cmd.to_owned(), "--package".to_owned(), spec.package.clone()]; - let all_targets = cmd != "run" && !snap.analysis.is_crate_no_std(spec.crate_id)?; + let all_targets = cmd != "run" && !is_crate_no_std; if all_targets { cargo_args.push("--all-targets".to_owned()); }