Fix private module loophole in the 'private type in public item' check

This commit is contained in:
Nick Cameron 2015-03-12 10:44:56 +13:00
parent ea8b82e90c
commit 46aa621452
13 changed files with 76 additions and 65 deletions

View file

@ -0,0 +1,28 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// Test that we properly check for private types in public signatures, even
// inside a private module (#22261).
mod a {
struct Priv;
pub fn expose_a() -> Priv { //~Error: private type in exported type signature
panic!();
}
mod b {
pub fn expose_b() -> super::Priv { //~Error: private type in exported type signature
panic!();
}
}
}
pub fn main() {}

View file

@ -1,31 +0,0 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// This tests that exports can have visible dependencies on things
// that are not exported, allowing for a sort of poor-man's ADT
mod foo {
// not exported
#[derive(Copy)]
enum t { t1, t2, }
impl PartialEq for t {
fn eq(&self, other: &t) -> bool {
((*self) as uint) == ((*other) as uint)
}
fn ne(&self, other: &t) -> bool { !(*self).eq(other) }
}
pub fn f() -> t { return t::t1; }
pub fn g(v: t) { assert!((v == t::t1)); }
}
pub fn main() { foo::g(foo::f()); }

View file

@ -11,7 +11,7 @@
#![deny(warnings)]
#![allow(unused_imports)]
enum Foo { A }
pub enum Foo { A }
mod bar {
pub fn normal(x: ::Foo) {
use Foo::A;