user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix from_over_into lint suggesting invalid code

Browse source
This commit is contained in:
KonaeAkira 2025-03-15 00:05:32 +01:00
parent da910b14e2
commit 4a324c9dff
1 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

20
clippy_lints/src/from_over_into.rs
View file

@ -176,8 +176,8 @@ fn convert_to_from(
return None;
};
let body = cx.tcx.hir_body(body_id);
let [input] = body.params else { return None };
let PatKind::Binding(.., self_ident, None) = input.pat.kind else {
let [self_param] = body.params else { return None };
let PatKind::Binding(.., self_ident, None) = self_param.pat.kind else {
return None;
};
@ -197,11 +197,21 @@ fn convert_to_from(
// fn into(self) -> T -> fn from(self) -> T
// ~~~~ ~~~~
(impl_item.ident.span, String::from("from")),
// fn into([mut] self) -> T -> fn into([mut] v: T) -> T
// ~~~~ ~~~~
(self_ident.span, format!("val: {from}")),
];
if self_ident.span.overlaps(self_param.ty_span) {
// fn into([mut] self) -> T -> fn into([mut] val: T) -> T
// ~~~~ ~~~~~~
suggestions.push((self_ident.span, format!("val: {from}")));
} else {
// fn into([mut] self: U) -> T -> fn into([mut] val: U) -> T
// ~~~~ ~~~
suggestions.push((self_ident.span, String::from("val")));
// fn into([mut] val: U) -> T -> fn into([mut] val: T) -> T
// ~ ~
suggestions.push((self_param.ty_span, from.to_owned()));
}
if let FnRetTy::Return(_) = sig.decl.output {
// fn into(self) -> T -> fn into(self) -> Self
// ~ ~~~~