user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix impl type parameter suggestion involving consts

Browse source
This commit is contained in:
mibac138 2021-05-06 14:33:23 +02:00
parent 1bb94fbbeb
commit 4c72efc816
4 changed files with 60 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/test/ui/const-generics/diagnostics.stderr
View file

@ -31,8 +31,8 @@ LL | impl<const N: u8> Foo for C<N, A> {}
| ^
help: you might be missing a type parameter
|
LL | impl<const N, T: u8> Foo for C<N, T> {}
| ^^^
LL | impl<const N: u8, T> Foo for C<N, T> {}
| ^^^
error[E0747]: unresolved item provided when a constant was expected
--> $DIR/diagnostics.rs:7:16

6
src/test/ui/missing/missing-items/missing-type-parameter2.rs
View file

@ -11,7 +11,11 @@ impl<T, const A: u8 = 2> X<N> {}
//~| ERROR defaults for const parameters are only allowed in `struct`, `enum`, `type`, or `trait` definitions
//~| ERROR unresolved item provided when a constant was expected
fn bar<const N: u8>(a: A) {}
fn foo(_: T) where T: Send {}
//~^ ERROR cannot find type `T` in this scope
//~| ERROR cannot find type `T` in this scope
fn bar<const N: u8>(_: A) {}
//~^ ERROR cannot find type `A` in this scope
fn main() {

54
src/test/ui/missing/missing-items/missing-type-parameter2.stderr
View file

@ -30,26 +30,62 @@ LL | impl<T, const A: u8 = 2> X<T> {}
| ^
help: you might be missing a type parameter
|
LL | impl<T, const A, N: u8 = 2> X<N> {}
| ^^^
LL | impl<T, const A: u8 = 2, N> X<N> {}
| ^^^
error[E0412]: cannot find type `A` in this scope
--> $DIR/missing-type-parameter2.rs:14:24
error[E0412]: cannot find type `T` in this scope
--> $DIR/missing-type-parameter2.rs:14:20
|
LL | struct X<const N: u8>();
| ------------------------ similarly named struct `X` defined here
...
LL | fn bar<const N: u8>(a: A) {}
LL | fn foo(_: T) where T: Send {}
| ^
|
help: a struct with a similar name exists
|
LL | fn foo(_: T) where X: Send {}
| ^
help: you might be missing a type parameter
|
LL | fn foo<T>(_: T) where T: Send {}
| ^^^
error[E0412]: cannot find type `T` in this scope
--> $DIR/missing-type-parameter2.rs:14:11
|
LL | struct X<const N: u8>();
| ------------------------ similarly named struct `X` defined here
...
LL | fn foo(_: T) where T: Send {}
| ^
|
help: a struct with a similar name exists
|
LL | fn foo(_: X) where T: Send {}
| ^
help: you might be missing a type parameter
|
LL | fn foo<T>(_: T) where T: Send {}
| ^^^
error[E0412]: cannot find type `A` in this scope
--> $DIR/missing-type-parameter2.rs:18:24
|
LL | struct X<const N: u8>();
| ------------------------ similarly named struct `X` defined here
...
LL | fn bar<const N: u8>(_: A) {}
| ^
|
help: a struct with a similar name exists
|
LL | fn bar<const N: u8>(a: X) {}
LL | fn bar<const N: u8>(_: X) {}
| ^
help: you might be missing a type parameter
|
LL | fn bar<const N, A: u8>(a: A) {}
| ^^^
LL | fn bar<const N: u8, A>(_: A) {}
| ^^^
error[E0747]: unresolved item provided when a constant was expected
--> $DIR/missing-type-parameter2.rs:6:8
@ -79,7 +115,7 @@ help: if this generic argument was intended as a const parameter, surround it wi
LL | impl<T, const A: u8 = 2> X<{ N }> {}
| ^ ^
error: aborting due to 6 previous errors
error: aborting due to 8 previous errors
Some errors have detailed explanations: E0412, E0747.
For more information about an error, try `rustc --explain E0412`.