user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add #[track_caller] to Duration Div impl

Browse source 
Previously the location of the divide-by-zero error condition would be
attributed to the code in the rust standard library, eg:

	thread 'main' panicked at /home/user/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/time.rs:1172:31:
	divide by zero error when dividing duration by scalar

With #[track_caller] the error is correctly attributed to the callee.
This commit is contained in:
Peter Todd 2025-02-18 04:56:03 +00:00
parent de91711756
commit 4e4cb10b84
No known key found for this signature in database
GPG key ID: 2E5CB5D535512F37
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
library/core/src/time.rs
View file

@ -1168,6 +1168,7 @@ impl Div<u32> for Duration {
type Output = Duration;
#[inline]
#[track_caller]
fn div(self, rhs: u32) -> Duration {
self.checked_div(rhs).expect("divide by zero error when dividing duration by scalar")
}
@ -1176,6 +1177,7 @@ impl Div<u32> for Duration {
#[stable(feature = "time_augmented_assignment", since = "1.9.0")]
impl DivAssign<u32> for Duration {
#[inline]
#[track_caller]
fn div_assign(&mut self, rhs: u32) {
*self = *self / rhs;
}