user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use def span for non-ascii ident feature gate error

Browse source
This commit is contained in:
Esteban Küber 2017-12-17 22:51:57 -08:00
parent 3cc68bac7c
commit 502d570b81
2 changed files with 11 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/libsyntax/feature_gate.rs
View file

@ -1341,7 +1341,9 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
fn visit_name(&mut self, sp: Span, name: ast::Name) {
if !name.as_str().is_ascii() {
gate_feature_post!(&self, non_ascii_idents, sp,
gate_feature_post!(&self,
non_ascii_idents,
self.context.parse_sess.codemap().def_span(sp),
"non-ascii idents are not fully supported.");
}
}

26
src/test/ui/feature-gate-non_ascii_idents.stderr
View file

@ -17,10 +17,8 @@ error: non-ascii idents are not fully supported. (see issue #28979)
error: non-ascii idents are not fully supported. (see issue #28979)
--> $DIR/feature-gate-non_ascii_idents.rs:15:1
|
15 | / mod föö { //~ ERROR non-ascii idents
16 | | pub fn bar() {}
17 | | }
| |_^
15 | mod föö { //~ ERROR non-ascii idents
| ^^^^^^^
|
= help: add #![feature(non_ascii_idents)] to the crate attributes to enable
@ -65,10 +63,8 @@ error: non-ascii idents are not fully supported. (see issue #28979)
error: non-ascii idents are not fully supported. (see issue #28979)
--> $DIR/feature-gate-non_ascii_idents.rs:29:1
|
29 | / struct Föö { //~ ERROR non-ascii idents
30 | | föö: isize //~ ERROR non-ascii idents
31 | | }
| |_^
29 | struct Föö { //~ ERROR non-ascii idents
| ^^^^^^^^^^
|
= help: add #![feature(non_ascii_idents)] to the crate attributes to enable
@ -83,22 +79,16 @@ error: non-ascii idents are not fully supported. (see issue #28979)
error: non-ascii idents are not fully supported. (see issue #28979)
--> $DIR/feature-gate-non_ascii_idents.rs:33:1
|
33 | / enum Bär { //~ ERROR non-ascii idents
34 | | Bäz { //~ ERROR non-ascii idents
35 | | qüx: isize //~ ERROR non-ascii idents
36 | | }
37 | | }
| |_^
33 | enum Bär { //~ ERROR non-ascii idents
| ^^^^^^^^
|
= help: add #![feature(non_ascii_idents)] to the crate attributes to enable
error: non-ascii idents are not fully supported. (see issue #28979)
--> $DIR/feature-gate-non_ascii_idents.rs:34:5
|
34 | / Bäz { //~ ERROR non-ascii idents
35 | | qüx: isize //~ ERROR non-ascii idents
36 | | }
| |_____^
34 | Bäz { //~ ERROR non-ascii idents
| ^^^
|
= help: add #![feature(non_ascii_idents)] to the crate attributes to enable