From 72ab4b4f0128cc94c5e0281ab48e68597d9c0d51 Mon Sep 17 00:00:00 2001 From: Matt Brubeck Date: Tue, 29 May 2018 11:26:10 -0700 Subject: [PATCH] Add std/core to prelude if extern_prelude enabled Fixes #50605 --- src/librustc_resolve/lib.rs | 12 ++++++++++- src/test/run-pass/extern-prelude-core.rs | 27 ++++++++++++++++++++++++ src/test/run-pass/extern-prelude-std.rs | 22 +++++++++++++++++++ 3 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 src/test/run-pass/extern-prelude-core.rs create mode 100644 src/test/run-pass/extern-prelude-std.rs diff --git a/src/librustc_resolve/lib.rs b/src/librustc_resolve/lib.rs index e05c6bf59edb..453627f3c36b 100644 --- a/src/librustc_resolve/lib.rs +++ b/src/librustc_resolve/lib.rs @@ -1610,6 +1610,16 @@ impl<'a> Resolver<'a> { DefCollector::new(&mut definitions, Mark::root()) .collect_root(crate_name, session.local_crate_disambiguator()); + let mut extern_prelude: FxHashSet = + session.opts.externs.iter().map(|kv| Symbol::intern(kv.0)).collect(); + if !attr::contains_name(&krate.attrs, "no_core") { + if !attr::contains_name(&krate.attrs, "no_std") { + extern_prelude.insert(Symbol::intern("std")); + } else { + extern_prelude.insert(Symbol::intern("core")); + } + } + let mut invocations = FxHashMap(); invocations.insert(Mark::root(), arenas.alloc_invocation_data(InvocationData::root(graph_root))); @@ -1630,7 +1640,7 @@ impl<'a> Resolver<'a> { // AST. graph_root, prelude: None, - extern_prelude: session.opts.externs.iter().map(|kv| Symbol::intern(kv.0)).collect(), + extern_prelude, has_self: FxHashSet(), field_names: FxHashMap(), diff --git a/src/test/run-pass/extern-prelude-core.rs b/src/test/run-pass/extern-prelude-core.rs new file mode 100644 index 000000000000..d0d01b34c6e9 --- /dev/null +++ b/src/test/run-pass/extern-prelude-core.rs @@ -0,0 +1,27 @@ +// Copyright 2018 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(extern_prelude, lang_items, start, alloc)] +#![no_std] + +extern crate std as other; + +mod foo { + pub fn test() { + let x = core::cmp::min(2, 3); + assert_eq!(x, 2); + } +} + +#[start] +fn start(_argc: isize, _argv: *const *const u8) -> isize { + foo::test(); + 0 +} diff --git a/src/test/run-pass/extern-prelude-std.rs b/src/test/run-pass/extern-prelude-std.rs new file mode 100644 index 000000000000..de73f1d22783 --- /dev/null +++ b/src/test/run-pass/extern-prelude-std.rs @@ -0,0 +1,22 @@ +// Copyright 2018 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(extern_prelude)] + +mod foo { + pub fn test() { + let x = std::cmp::min(2, 3); + assert_eq!(x, 2); + } +} + +fn main() { + foo::test(); +}