user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve settings.js code by using 'onEachLazy' directly instead of looping through DOM iterators

Browse source
This commit is contained in:
Guillaume Gomez 2020-11-08 17:10:18 +01:00
parent 704050da23
commit 589588ce7b
1 changed files with 22 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

55
src/librustdoc/html/static/settings.js
View file

@ -30,41 +30,30 @@
}
function setEvents() {
var elems = {
toggles: Array.prototype.slice.call(document.getElementsByClassName("slider")),
selects: Array.prototype.slice.call(document.getElementsByClassName("select-wrapper")),
};
var i;
if (elems.toggles && elems.toggles.length > 0) {
for (i = 0; i < elems.toggles.length; ++i) {
var toggle = elems.toggles[i].previousElementSibling;
var settingId = toggle.id;
var settingValue = getSettingValue(settingId);
if (settingValue !== null) {
toggle.checked = settingValue === "true";
}
toggle.onchange = function() {
changeSetting(this.id, this.checked);
};
toggle.onkeyup = handleKey;
toggle.onkeyrelease = handleKey;
onEachLazy(document.getElementsByClassName("slider"), function(elem) {
var toggle = elem.previousElementSibling;
var settingId = toggle.id;
var settingValue = getSettingValue(settingId);
if (settingValue !== null) {
toggle.checked = settingValue === "true";
}
}
if (elems.selects && elems.selects.length > 0) {
for (i = 0; i < elems.selects.length; ++i) {
var select = elems.selects[i].getElementsByTagName("select")[0];
var settingId = select.id;
var settingValue = getSettingValue(settingId);
if (settingValue !== null) {
select.value = settingValue;
}
select.onchange = function() {
changeSetting(this.id, this.value);
};
toggle.onchange = function() {
changeSetting(this.id, this.checked);
};
toggle.onkeyup = handleKey;
toggle.onkeyrelease = handleKey;
});
onEachLazy(document.getElementsByClassName("select-wrapper"), function(elem) {
var select = elem.getElementsByTagName("select")[0];
var settingId = select.id;
var settingValue = getSettingValue(settingId);
if (settingValue !== null) {
select.value = settingValue;
}
}
select.onchange = function() {
changeSetting(this.id, this.value);
};
});
}
window.addEventListener("DOMContentLoaded", setEvents);