From 5d06fbb46d2434c50d3c50695e4a0f0bb187fdb5 Mon Sep 17 00:00:00 2001
From: Kristof Mattei <864376+Kristof-Mattei@users.noreply.github.com>
Date: Sun, 14 Jan 2024 09:25:31 -0700
Subject: [PATCH] fix: don't allocate new string when not needed

---
 clippy_lints/src/cargo/multiple_crate_versions.rs | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/clippy_lints/src/cargo/multiple_crate_versions.rs b/clippy_lints/src/cargo/multiple_crate_versions.rs
index a28934266cbc..8e86c0017e1d 100644
--- a/clippy_lints/src/cargo/multiple_crate_versions.rs
+++ b/clippy_lints/src/cargo/multiple_crate_versions.rs
@@ -16,7 +16,12 @@ pub(super) fn check(cx: &LateContext<'_>, metadata: &Metadata) {
 
     if let Some(resolve) = &metadata.resolve
         && let Some(local_id) = packages.iter().find_map(|p| {
-            if p.name.replace('-', "_") == local_name.as_str() {
+            if p.name
+                .chars()
+                .into_iter()
+                .map(|c| if c == '-' { '_' } else { c })
+                .eq(local_name.as_str().chars())
+            {
                 Some(&p.id)
             } else {
                 None