From 5d74e2096b1335fe4a913b7ffbdac5bbdc6c8f5a Mon Sep 17 00:00:00 2001 From: Manish Goregaokar Date: Thu, 19 Jul 2018 00:53:23 -0700 Subject: [PATCH] Remove import of rustc --- clippy_lints/src/approx_const.rs | 1 + clippy_lints/src/arithmetic.rs | 1 + clippy_lints/src/assign_ops.rs | 1 + clippy_lints/src/attrs.rs | 1 + clippy_lints/src/bit_mask.rs | 1 + clippy_lints/src/blacklisted_name.rs | 1 + clippy_lints/src/block_in_if_condition.rs | 1 + clippy_lints/src/booleans.rs | 1 + clippy_lints/src/bytecount.rs | 1 + clippy_lints/src/collapsible_if.rs | 1 + clippy_lints/src/const_static_lifetime.rs | 1 + clippy_lints/src/consts.rs | 1 + clippy_lints/src/copies.rs | 1 + clippy_lints/src/cyclomatic_complexity.rs | 1 + clippy_lints/src/default_trait_access.rs | 1 + clippy_lints/src/derive.rs | 1 + clippy_lints/src/doc.rs | 1 + clippy_lints/src/double_comparison.rs | 1 + clippy_lints/src/double_parens.rs | 1 + clippy_lints/src/drop_forget_ref.rs | 1 + clippy_lints/src/duration_subsec.rs | 1 + clippy_lints/src/else_if_without_else.rs | 1 + clippy_lints/src/empty_enum.rs | 1 + clippy_lints/src/entry.rs | 1 + clippy_lints/src/enum_clike.rs | 1 + clippy_lints/src/enum_glob_use.rs | 1 + clippy_lints/src/enum_variants.rs | 1 + clippy_lints/src/eq_op.rs | 1 + clippy_lints/src/erasing_op.rs | 1 + clippy_lints/src/escape.rs | 1 + clippy_lints/src/eta_reduction.rs | 1 + clippy_lints/src/eval_order_dependence.rs | 1 + clippy_lints/src/excessive_precision.rs | 1 + clippy_lints/src/explicit_write.rs | 1 + clippy_lints/src/fallible_impl_from.rs | 1 + clippy_lints/src/format.rs | 1 + clippy_lints/src/formatting.rs | 1 + clippy_lints/src/functions.rs | 1 + clippy_lints/src/identity_conversion.rs | 1 + clippy_lints/src/identity_op.rs | 1 + clippy_lints/src/if_let_redundant_pattern_matching.rs | 1 + clippy_lints/src/if_not_else.rs | 1 + clippy_lints/src/indexing_slicing.rs | 1 + clippy_lints/src/infallible_destructuring_match.rs | 1 + clippy_lints/src/infinite_iter.rs | 1 + clippy_lints/src/inherent_impl.rs | 1 + clippy_lints/src/inline_fn_without_body.rs | 1 + clippy_lints/src/int_plus_one.rs | 1 + clippy_lints/src/invalid_ref.rs | 1 + clippy_lints/src/items_after_statements.rs | 1 + clippy_lints/src/large_enum_variant.rs | 1 + clippy_lints/src/len_zero.rs | 1 + clippy_lints/src/let_if_seq.rs | 1 + clippy_lints/src/lib.rs | 3 --- clippy_lints/src/lifetimes.rs | 1 + clippy_lints/src/literal_representation.rs | 1 + clippy_lints/src/loops.rs | 1 + clippy_lints/src/map_clone.rs | 1 + clippy_lints/src/map_unit_fn.rs | 1 + clippy_lints/src/matches.rs | 1 + clippy_lints/src/mem_forget.rs | 1 + clippy_lints/src/methods.rs | 1 + clippy_lints/src/minmax.rs | 1 + clippy_lints/src/misc.rs | 1 + clippy_lints/src/misc_early.rs | 1 + clippy_lints/src/missing_doc.rs | 1 + clippy_lints/src/missing_inline.rs | 1 + clippy_lints/src/multiple_crate_versions.rs | 1 + clippy_lints/src/mut_mut.rs | 1 + clippy_lints/src/mut_reference.rs | 1 + clippy_lints/src/mutex_atomic.rs | 1 + clippy_lints/src/needless_bool.rs | 1 + clippy_lints/src/needless_borrow.rs | 1 + clippy_lints/src/needless_borrowed_ref.rs | 1 + clippy_lints/src/needless_continue.rs | 1 + clippy_lints/src/needless_pass_by_value.rs | 1 + clippy_lints/src/needless_update.rs | 1 + clippy_lints/src/neg_cmp_op_on_partial_ord.rs | 1 + clippy_lints/src/neg_multiply.rs | 1 + clippy_lints/src/new_without_default.rs | 1 + clippy_lints/src/no_effect.rs | 1 + clippy_lints/src/non_copy_const.rs | 1 + clippy_lints/src/non_expressive_names.rs | 1 + clippy_lints/src/ok_if_let.rs | 1 + clippy_lints/src/open_options.rs | 1 + clippy_lints/src/overflow_check_conditional.rs | 1 + clippy_lints/src/panic_unimplemented.rs | 1 + clippy_lints/src/partialeq_ne_impl.rs | 1 + clippy_lints/src/precedence.rs | 1 + clippy_lints/src/ptr.rs | 1 + clippy_lints/src/question_mark.rs | 1 + clippy_lints/src/ranges.rs | 1 + clippy_lints/src/redundant_field_names.rs | 1 + clippy_lints/src/reference.rs | 1 + clippy_lints/src/regex.rs | 1 + clippy_lints/src/replace_consts.rs | 1 + clippy_lints/src/returns.rs | 1 + clippy_lints/src/serde_api.rs | 1 + clippy_lints/src/shadow.rs | 1 + clippy_lints/src/strings.rs | 1 + clippy_lints/src/suspicious_trait_impl.rs | 1 + clippy_lints/src/swap.rs | 1 + clippy_lints/src/temporary_assignment.rs | 1 + clippy_lints/src/transmute.rs | 1 + clippy_lints/src/trivially_copy_pass_by_ref.rs | 1 + clippy_lints/src/types.rs | 1 + clippy_lints/src/unicode.rs | 1 + clippy_lints/src/unsafe_removed_from_name.rs | 1 + clippy_lints/src/unused_io_amount.rs | 1 + clippy_lints/src/unused_label.rs | 1 + clippy_lints/src/unwrap.rs | 1 + clippy_lints/src/use_self.rs | 1 + clippy_lints/src/utils/author.rs | 1 + clippy_lints/src/utils/inspector.rs | 1 + clippy_lints/src/utils/internal_lints.rs | 1 + clippy_lints/src/vec.rs | 1 + clippy_lints/src/write.rs | 1 + clippy_lints/src/zero_div_zero.rs | 1 + 118 files changed, 117 insertions(+), 3 deletions(-) diff --git a/clippy_lints/src/approx_const.rs b/clippy_lints/src/approx_const.rs index 13e1dbe3c0a7..b9de43762e09 100644 --- a/clippy_lints/src/approx_const.rs +++ b/clippy_lints/src/approx_const.rs @@ -1,6 +1,7 @@ use crate::utils::span_lint; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use std::f64::consts as f64; use syntax::ast::{FloatTy, Lit, LitKind}; use syntax::symbol; diff --git a/clippy_lints/src/arithmetic.rs b/clippy_lints/src/arithmetic.rs index 0ab7a3388637..b3d78d2d13f7 100644 --- a/clippy_lints/src/arithmetic.rs +++ b/clippy_lints/src/arithmetic.rs @@ -1,6 +1,7 @@ use crate::utils::span_lint; use rustc::hir; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::codemap::Span; /// **What it does:** Checks for plain integer arithmetic. diff --git a/clippy_lints/src/assign_ops.rs b/clippy_lints/src/assign_ops.rs index 272b6c5a84dc..5acdf8172e68 100644 --- a/clippy_lints/src/assign_ops.rs +++ b/clippy_lints/src/assign_ops.rs @@ -3,6 +3,7 @@ use crate::utils::{higher, sugg}; use rustc::hir; use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor}; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast; /// **What it does:** Checks for compound assignment operations (`+=` and diff --git a/clippy_lints/src/attrs.rs b/clippy_lints/src/attrs.rs index 5d5e2f964b09..c19f075cea37 100644 --- a/clippy_lints/src/attrs.rs +++ b/clippy_lints/src/attrs.rs @@ -7,6 +7,7 @@ use crate::utils::{ }; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, TyCtxt}; use semver::Version; use syntax::ast::{AttrStyle, Attribute, Lit, LitKind, MetaItemKind, NestedMetaItem, NestedMetaItemKind}; diff --git a/clippy_lints/src/bit_mask.rs b/clippy_lints/src/bit_mask.rs index 25d5e4d4db1d..e772042f0a69 100644 --- a/clippy_lints/src/bit_mask.rs +++ b/clippy_lints/src/bit_mask.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::LitKind; use syntax::codemap::Span; use crate::utils::{span_lint, span_lint_and_then}; diff --git a/clippy_lints/src/blacklisted_name.rs b/clippy_lints/src/blacklisted_name.rs index 296603992330..cfec01d14aed 100644 --- a/clippy_lints/src/blacklisted_name.rs +++ b/clippy_lints/src/blacklisted_name.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::span_lint; diff --git a/clippy_lints/src/block_in_if_condition.rs b/clippy_lints/src/block_in_if_condition.rs index 94e17290b6a6..7d4d667da9a0 100644 --- a/clippy_lints/src/block_in_if_condition.rs +++ b/clippy_lints/src/block_in_if_condition.rs @@ -1,4 +1,5 @@ use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor}; use crate::utils::*; diff --git a/clippy_lints/src/booleans.rs b/clippy_lints/src/booleans.rs index e23978ebc1d4..7d627f498367 100644 --- a/clippy_lints/src/booleans.rs +++ b/clippy_lints/src/booleans.rs @@ -1,4 +1,5 @@ use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::hir::intravisit::*; use syntax::ast::{LitKind, NodeId, DUMMY_NODE_ID}; diff --git a/clippy_lints/src/bytecount.rs b/clippy_lints/src/bytecount.rs index aaa924e95b1e..f27961783e7f 100644 --- a/clippy_lints/src/bytecount.rs +++ b/clippy_lints/src/bytecount.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use syntax::ast::{Name, UintTy}; use crate::utils::{contains_name, get_pat_name, match_type, paths, single_segment_path, snippet, span_lint_and_sugg, diff --git a/clippy_lints/src/collapsible_if.rs b/clippy_lints/src/collapsible_if.rs index 786148f6eec6..a2d280e75e3c 100644 --- a/clippy_lints/src/collapsible_if.rs +++ b/clippy_lints/src/collapsible_if.rs @@ -13,6 +13,7 @@ //! This lint is **warn** by default use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast; use crate::utils::{in_macro, snippet_block, span_lint_and_sugg, span_lint_and_then}; diff --git a/clippy_lints/src/const_static_lifetime.rs b/clippy_lints/src/const_static_lifetime.rs index bde5ee4dc8b6..8bb209a64902 100644 --- a/clippy_lints/src/const_static_lifetime.rs +++ b/clippy_lints/src/const_static_lifetime.rs @@ -1,5 +1,6 @@ use syntax::ast::*; use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use crate::utils::{in_macro, snippet, span_lint_and_then}; /// **What it does:** Checks for constants with an explicit `'static` lifetime. diff --git a/clippy_lints/src/consts.rs b/clippy_lints/src/consts.rs index d7323337f247..878ad2763438 100644 --- a/clippy_lints/src/consts.rs +++ b/clippy_lints/src/consts.rs @@ -2,6 +2,7 @@ #![allow(float_cmp)] use rustc::lint::LateContext; +use rustc::{span_bug, bug}; use rustc::hir::def::Def; use rustc::hir::*; use rustc::ty::{self, Ty, TyCtxt, Instance}; diff --git a/clippy_lints/src/copies.rs b/clippy_lints/src/copies.rs index 9e9a641ce27e..c0830c5ea316 100644 --- a/clippy_lints/src/copies.rs +++ b/clippy_lints/src/copies.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::Ty; use rustc::hir::*; use std::collections::HashMap; diff --git a/clippy_lints/src/cyclomatic_complexity.rs b/clippy_lints/src/cyclomatic_complexity.rs index b1b667d046ca..c397ca7824e2 100644 --- a/clippy_lints/src/cyclomatic_complexity.rs +++ b/clippy_lints/src/cyclomatic_complexity.rs @@ -2,6 +2,7 @@ use rustc::cfg::CFG; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::ty; use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor}; diff --git a/clippy_lints/src/default_trait_access.rs b/clippy_lints/src/default_trait_access.rs index 900dabc96505..915386757f0e 100644 --- a/clippy_lints/src/default_trait_access.rs +++ b/clippy_lints/src/default_trait_access.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::TypeVariants; use crate::utils::{any_parent_is_automatically_derived, match_def_path, opt_def_id, paths, span_lint_and_sugg}; diff --git a/clippy_lints/src/derive.rs b/clippy_lints/src/derive.rs index 0d0eb27fb7db..02816ce9e4e5 100644 --- a/clippy_lints/src/derive.rs +++ b/clippy_lints/src/derive.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, Ty}; use rustc::hir::*; use syntax::codemap::Span; diff --git a/clippy_lints/src/doc.rs b/clippy_lints/src/doc.rs index dfd59af9adb3..a298137976b7 100644 --- a/clippy_lints/src/doc.rs +++ b/clippy_lints/src/doc.rs @@ -1,6 +1,7 @@ use itertools::Itertools; use pulldown_cmark; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast; use syntax::codemap::{BytePos, Span}; use syntax_pos::Pos; diff --git a/clippy_lints/src/double_comparison.rs b/clippy_lints/src/double_comparison.rs index e2ea5723a98e..434ccb69921e 100644 --- a/clippy_lints/src/double_comparison.rs +++ b/clippy_lints/src/double_comparison.rs @@ -2,6 +2,7 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::codemap::Span; use crate::utils::{snippet, span_lint_and_sugg, SpanlessEq}; diff --git a/clippy_lints/src/double_parens.rs b/clippy_lints/src/double_parens.rs index 2b81e1db2575..2617eab0aa7d 100644 --- a/clippy_lints/src/double_parens.rs +++ b/clippy_lints/src/double_parens.rs @@ -1,5 +1,6 @@ use syntax::ast::*; use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass}; +use rustc::{declare_lint, lint_array}; /// **What it does:** Checks for unnecessary double parentheses. /// diff --git a/clippy_lints/src/drop_forget_ref.rs b/clippy_lints/src/drop_forget_ref.rs index b0625e10d761..8fb01d79a1ee 100644 --- a/clippy_lints/src/drop_forget_ref.rs +++ b/clippy_lints/src/drop_forget_ref.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use rustc::hir::*; use crate::utils::{is_copy, match_def_path, opt_def_id, paths, span_note_and_lint}; diff --git a/clippy_lints/src/duration_subsec.rs b/clippy_lints/src/duration_subsec.rs index d374973e35b4..4679ce158712 100644 --- a/clippy_lints/src/duration_subsec.rs +++ b/clippy_lints/src/duration_subsec.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::codemap::Spanned; use crate::consts::{constant, Constant}; diff --git a/clippy_lints/src/else_if_without_else.rs b/clippy_lints/src/else_if_without_else.rs index 96c215df405b..b84069048218 100644 --- a/clippy_lints/src/else_if_without_else.rs +++ b/clippy_lints/src/else_if_without_else.rs @@ -1,6 +1,7 @@ //! lint on if expressions with an else if, but without a final else branch use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::*; use crate::utils::{in_external_macro, span_lint_and_sugg}; diff --git a/clippy_lints/src/empty_enum.rs b/clippy_lints/src/empty_enum.rs index 1ca32cf2263e..803ba34a8657 100644 --- a/clippy_lints/src/empty_enum.rs +++ b/clippy_lints/src/empty_enum.rs @@ -1,6 +1,7 @@ //! lint when there is an enum with no variants use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::span_lint_and_then; diff --git a/clippy_lints/src/entry.rs b/clippy_lints/src/entry.rs index f29c2d1bb6d0..8f731e992ab6 100644 --- a/clippy_lints/src/entry.rs +++ b/clippy_lints/src/entry.rs @@ -1,6 +1,7 @@ use rustc::hir::*; use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor}; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::codemap::Span; use crate::utils::SpanlessEq; use crate::utils::{get_item_name, match_type, paths, snippet, span_lint_and_then, walk_ptrs_ty}; diff --git a/clippy_lints/src/enum_clike.rs b/clippy_lints/src/enum_clike.rs index 6584bc6ffa95..62cbead19290 100644 --- a/clippy_lints/src/enum_clike.rs +++ b/clippy_lints/src/enum_clike.rs @@ -2,6 +2,7 @@ //! don't fit into an `i32` use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::ty; use rustc::ty::subst::Substs; diff --git a/clippy_lints/src/enum_glob_use.rs b/clippy_lints/src/enum_glob_use.rs index 042a96a21c85..10cf497725c5 100644 --- a/clippy_lints/src/enum_glob_use.rs +++ b/clippy_lints/src/enum_glob_use.rs @@ -3,6 +3,7 @@ use rustc::hir::*; use rustc::hir::def::Def; use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use syntax::ast::NodeId; use syntax::codemap::Span; use crate::utils::span_lint; diff --git a/clippy_lints/src/enum_variants.rs b/clippy_lints/src/enum_variants.rs index d272cab0a0df..6a14638057a8 100644 --- a/clippy_lints/src/enum_variants.rs +++ b/clippy_lints/src/enum_variants.rs @@ -1,6 +1,7 @@ //! lint on enum variants that are prefixed or suffixed by the same characters use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::*; use syntax::codemap::Span; use syntax::symbol::LocalInternedString; diff --git a/clippy_lints/src/eq_op.rs b/clippy_lints/src/eq_op.rs index f58b499d8065..dfbc3b126336 100644 --- a/clippy_lints/src/eq_op.rs +++ b/clippy_lints/src/eq_op.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use crate::utils::{in_macro, implements_trait, is_copy, multispan_sugg, snippet, span_lint, span_lint_and_then, SpanlessEq}; /// **What it does:** Checks for equal operands to comparison, logical and diff --git a/clippy_lints/src/erasing_op.rs b/clippy_lints/src/erasing_op.rs index acede5d1a132..102769a375e1 100644 --- a/clippy_lints/src/erasing_op.rs +++ b/clippy_lints/src/erasing_op.rs @@ -1,6 +1,7 @@ use crate::consts::{constant_simple, Constant}; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::codemap::Span; use crate::utils::{in_macro, span_lint}; diff --git a/clippy_lints/src/escape.rs b/clippy_lints/src/escape.rs index a03dc7b62690..ff5c85b6009e 100644 --- a/clippy_lints/src/escape.rs +++ b/clippy_lints/src/escape.rs @@ -2,6 +2,7 @@ use rustc::hir::*; use rustc::hir::intravisit as visit; use rustc::hir::map::Node::{NodeExpr, NodeStmt}; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::middle::expr_use_visitor::*; use rustc::middle::mem_categorization::{cmt_, Categorization}; use rustc::ty::{self, Ty}; diff --git a/clippy_lints/src/eta_reduction.rs b/clippy_lints/src/eta_reduction.rs index 87f0e64caafa..7b6623ed29b2 100644 --- a/clippy_lints/src/eta_reduction.rs +++ b/clippy_lints/src/eta_reduction.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use rustc::hir::*; use crate::utils::{is_adjusted, iter_input_pats, snippet_opt, span_lint_and_then}; diff --git a/clippy_lints/src/eval_order_dependence.rs b/clippy_lints/src/eval_order_dependence.rs index 58436bd897bb..33f6295a23bd 100644 --- a/clippy_lints/src/eval_order_dependence.rs +++ b/clippy_lints/src/eval_order_dependence.rs @@ -2,6 +2,7 @@ use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor}; use rustc::hir::*; use rustc::ty; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast; use crate::utils::{get_parent_expr, span_lint, span_note_and_lint}; diff --git a/clippy_lints/src/excessive_precision.rs b/clippy_lints/src/excessive_precision.rs index 24bbf6692059..a1c4484a2e55 100644 --- a/clippy_lints/src/excessive_precision.rs +++ b/clippy_lints/src/excessive_precision.rs @@ -1,5 +1,6 @@ use rustc::hir; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::TypeVariants; use std::f32; use std::f64; diff --git a/clippy_lints/src/explicit_write.rs b/clippy_lints/src/explicit_write.rs index 019d21f81e0e..554d52d4499d 100644 --- a/clippy_lints/src/explicit_write.rs +++ b/clippy_lints/src/explicit_write.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use crate::utils::{is_expn_of, match_def_path, resolve_node, span_lint}; use crate::utils::opt_def_id; diff --git a/clippy_lints/src/fallible_impl_from.rs b/clippy_lints/src/fallible_impl_from.rs index 1ea000d3611b..b6136708e18b 100644 --- a/clippy_lints/src/fallible_impl_from.rs +++ b/clippy_lints/src/fallible_impl_from.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir; use rustc::ty; use syntax_pos::Span; diff --git a/clippy_lints/src/format.rs b/clippy_lints/src/format.rs index e88f03868939..31ae3eb0fec4 100644 --- a/clippy_lints/src/format.rs +++ b/clippy_lints/src/format.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use syntax::ast::LitKind; use syntax_pos::Span; diff --git a/clippy_lints/src/formatting.rs b/clippy_lints/src/formatting.rs index 8008bb3ed669..784461c23ee8 100644 --- a/clippy_lints/src/formatting.rs +++ b/clippy_lints/src/formatting.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast; use crate::utils::{differing_macro_contexts, in_macro, snippet_opt, span_note_and_lint}; use syntax::ptr::P; diff --git a/clippy_lints/src/functions.rs b/clippy_lints/src/functions.rs index 164380923159..f58a91bc211d 100644 --- a/clippy_lints/src/functions.rs +++ b/clippy_lints/src/functions.rs @@ -1,6 +1,7 @@ use rustc::hir::intravisit; use rustc::hir; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use rustc::hir::def::Def; use std::collections::HashSet; diff --git a/clippy_lints/src/identity_conversion.rs b/clippy_lints/src/identity_conversion.rs index 32ae8bcb29f8..a0705f62544b 100644 --- a/clippy_lints/src/identity_conversion.rs +++ b/clippy_lints/src/identity_conversion.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use syntax::ast::NodeId; use crate::utils::{in_macro, match_def_path, match_trait_method, same_tys, snippet, span_lint_and_then}; diff --git a/clippy_lints/src/identity_op.rs b/clippy_lints/src/identity_op.rs index 92e07401818e..3a8a366890a7 100644 --- a/clippy_lints/src/identity_op.rs +++ b/clippy_lints/src/identity_op.rs @@ -1,6 +1,7 @@ use crate::consts::{constant_simple, Constant}; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::codemap::Span; use crate::utils::{in_macro, snippet, span_lint, unsext, clip}; use rustc::ty; diff --git a/clippy_lints/src/if_let_redundant_pattern_matching.rs b/clippy_lints/src/if_let_redundant_pattern_matching.rs index 17dcf571fbf0..bc97584a23d8 100644 --- a/clippy_lints/src/if_let_redundant_pattern_matching.rs +++ b/clippy_lints/src/if_let_redundant_pattern_matching.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::{match_qpath, paths, snippet, span_lint_and_then}; diff --git a/clippy_lints/src/if_not_else.rs b/clippy_lints/src/if_not_else.rs index 22ca1a61c9b2..eea83ca6b885 100644 --- a/clippy_lints/src/if_not_else.rs +++ b/clippy_lints/src/if_not_else.rs @@ -2,6 +2,7 @@ //! on the condition use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::*; use crate::utils::{in_external_macro, span_help_and_lint}; diff --git a/clippy_lints/src/indexing_slicing.rs b/clippy_lints/src/indexing_slicing.rs index 8176408e7208..aaea60f2c05a 100644 --- a/clippy_lints/src/indexing_slicing.rs +++ b/clippy_lints/src/indexing_slicing.rs @@ -6,6 +6,7 @@ use crate::utils::higher; use crate::utils::higher::Range; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use syntax::ast::RangeLimits; diff --git a/clippy_lints/src/infallible_destructuring_match.rs b/clippy_lints/src/infallible_destructuring_match.rs index 9abd9754d679..0f1ccddb3c44 100644 --- a/clippy_lints/src/infallible_destructuring_match.rs +++ b/clippy_lints/src/infallible_destructuring_match.rs @@ -1,6 +1,7 @@ use super::utils::{get_arg_name, match_var, remove_blocks, snippet, span_lint_and_sugg}; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; /// **What it does:** Checks for matches being used to destructure a single-variant enum /// or tuple struct where a `let` will suffice. diff --git a/clippy_lints/src/infinite_iter.rs b/clippy_lints/src/infinite_iter.rs index a979486945a7..3f461a07ab2b 100644 --- a/clippy_lints/src/infinite_iter.rs +++ b/clippy_lints/src/infinite_iter.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use crate::utils::{get_trait_def_id, higher, implements_trait, match_qpath, paths, span_lint}; /// **What it does:** Checks for iteration that is guaranteed to be infinite. diff --git a/clippy_lints/src/inherent_impl.rs b/clippy_lints/src/inherent_impl.rs index 9fb9a162cde6..fc06af81574e 100644 --- a/clippy_lints/src/inherent_impl.rs +++ b/clippy_lints/src/inherent_impl.rs @@ -2,6 +2,7 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use std::collections::HashMap; use std::default::Default; use syntax_pos::Span; diff --git a/clippy_lints/src/inline_fn_without_body.rs b/clippy_lints/src/inline_fn_without_body.rs index 8dab9fbd12f6..b308e3ca81f5 100644 --- a/clippy_lints/src/inline_fn_without_body.rs +++ b/clippy_lints/src/inline_fn_without_body.rs @@ -1,6 +1,7 @@ //! checks for `#[inline]` on trait methods without bodies use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use syntax::ast::{Attribute, Name}; use crate::utils::span_lint_and_then; diff --git a/clippy_lints/src/int_plus_one.rs b/clippy_lints/src/int_plus_one.rs index 8daf3d296c74..490d06f259fe 100644 --- a/clippy_lints/src/int_plus_one.rs +++ b/clippy_lints/src/int_plus_one.rs @@ -1,6 +1,7 @@ //! lint on blocks unnecessarily using >= with a + 1 or - 1 use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::*; use crate::utils::{snippet_opt, span_lint_and_then}; diff --git a/clippy_lints/src/invalid_ref.rs b/clippy_lints/src/invalid_ref.rs index 255efa741659..8fd097edafd8 100644 --- a/clippy_lints/src/invalid_ref.rs +++ b/clippy_lints/src/invalid_ref.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use rustc::hir::*; use crate::utils::{match_def_path, opt_def_id, paths, span_help_and_lint}; diff --git a/clippy_lints/src/items_after_statements.rs b/clippy_lints/src/items_after_statements.rs index 685c91c04575..61eaa7bea6ed 100644 --- a/clippy_lints/src/items_after_statements.rs +++ b/clippy_lints/src/items_after_statements.rs @@ -1,6 +1,7 @@ //! lint when items are used after statements use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::*; use crate::utils::{in_macro, span_lint}; diff --git a/clippy_lints/src/large_enum_variant.rs b/clippy_lints/src/large_enum_variant.rs index 926e3a3033f8..f29e50403547 100644 --- a/clippy_lints/src/large_enum_variant.rs +++ b/clippy_lints/src/large_enum_variant.rs @@ -1,6 +1,7 @@ //! lint when there is a large size difference between variants on an enum use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::{snippet_opt, span_lint_and_then}; use rustc::ty::layout::LayoutOf; diff --git a/clippy_lints/src/len_zero.rs b/clippy_lints/src/len_zero.rs index bd02eb5c81f1..e3ff60d30a2f 100644 --- a/clippy_lints/src/len_zero.rs +++ b/clippy_lints/src/len_zero.rs @@ -1,6 +1,7 @@ use rustc::hir::def_id::DefId; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use std::collections::HashSet; use syntax::ast::{Lit, LitKind, Name}; diff --git a/clippy_lints/src/let_if_seq.rs b/clippy_lints/src/let_if_seq.rs index a72e09f9fdf0..dd8d1d175ccc 100644 --- a/clippy_lints/src/let_if_seq.rs +++ b/clippy_lints/src/let_if_seq.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir; use rustc::hir::BindingAnnotation; use rustc::hir::def::Def; diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs index 02e92f1f4074..ac52c82b6025 100644 --- a/clippy_lints/src/lib.rs +++ b/clippy_lints/src/lib.rs @@ -15,9 +15,6 @@ #![warn(rust_2018_idioms)] #![allow(macro_use_extern_crate)] -#[macro_use] -extern crate rustc; - use toml; use rustc_plugin; diff --git a/clippy_lints/src/lifetimes.rs b/clippy_lints/src/lifetimes.rs index 1b371a8141ef..edd144d8de44 100644 --- a/clippy_lints/src/lifetimes.rs +++ b/clippy_lints/src/lifetimes.rs @@ -1,5 +1,6 @@ use crate::reexport::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::def::Def; use rustc::hir::*; use rustc::hir::intravisit::*; diff --git a/clippy_lints/src/literal_representation.rs b/clippy_lints/src/literal_representation.rs index 9b6c30f7f4ca..2788258a0cd8 100644 --- a/clippy_lints/src/literal_representation.rs +++ b/clippy_lints/src/literal_representation.rs @@ -2,6 +2,7 @@ //! floating-point literal expressions. use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::*; use syntax_pos; use crate::utils::{in_external_macro, snippet_opt, span_lint_and_sugg}; diff --git a/clippy_lints/src/loops.rs b/clippy_lints/src/loops.rs index e7da7bde30f2..f975df6001e0 100644 --- a/clippy_lints/src/loops.rs +++ b/clippy_lints/src/loops.rs @@ -6,6 +6,7 @@ use rustc::hir::def_id; use rustc::hir::intravisit::{walk_block, walk_decl, walk_expr, walk_pat, walk_stmt, NestedVisitorMap, Visitor}; use rustc::hir::map::Node::{NodeBlock, NodeExpr, NodeStmt}; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::middle::region; // use rustc::middle::region::CodeExtent; use rustc::middle::expr_use_visitor::*; diff --git a/clippy_lints/src/map_clone.rs b/clippy_lints/src/map_clone.rs index 01ce702c17cf..40bb23649358 100644 --- a/clippy_lints/src/map_clone.rs +++ b/clippy_lints/src/map_clone.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::ty; use syntax::ast; diff --git a/clippy_lints/src/map_unit_fn.rs b/clippy_lints/src/map_unit_fn.rs index 8df573e4c725..99df6a41eef2 100644 --- a/clippy_lints/src/map_unit_fn.rs +++ b/clippy_lints/src/map_unit_fn.rs @@ -1,5 +1,6 @@ use rustc::hir; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use rustc_errors::Applicability; use syntax::codemap::Span; diff --git a/clippy_lints/src/matches.rs b/clippy_lints/src/matches.rs index c82d156462d4..82ed199e0cb0 100644 --- a/clippy_lints/src/matches.rs +++ b/clippy_lints/src/matches.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, Ty}; use std::cmp::Ordering; use std::collections::Bound; diff --git a/clippy_lints/src/mem_forget.rs b/clippy_lints/src/mem_forget.rs index 11cf8a9a791a..88c244586468 100644 --- a/clippy_lints/src/mem_forget.rs +++ b/clippy_lints/src/mem_forget.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::{Expr, ExprKind}; use crate::utils::{match_def_path, opt_def_id, paths, span_lint}; diff --git a/clippy_lints/src/methods.rs b/clippy_lints/src/methods.rs index 26a0b66094fe..f878102a52e8 100644 --- a/clippy_lints/src/methods.rs +++ b/clippy_lints/src/methods.rs @@ -1,5 +1,6 @@ use rustc::hir; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, Ty}; use rustc::hir::def::Def; use std::borrow::Cow; diff --git a/clippy_lints/src/minmax.rs b/clippy_lints/src/minmax.rs index fa2c9fda731e..498f9ef4743f 100644 --- a/clippy_lints/src/minmax.rs +++ b/clippy_lints/src/minmax.rs @@ -2,6 +2,7 @@ use crate::consts::{constant_simple, Constant}; use crate::utils::{match_def_path, opt_def_id, paths, span_lint}; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use std::cmp::Ordering; /// **What it does:** Checks for expressions where `std::cmp::min` and `max` are diff --git a/clippy_lints/src/misc.rs b/clippy_lints/src/misc.rs index c5440420fc1e..c517d4a44eec 100644 --- a/clippy_lints/src/misc.rs +++ b/clippy_lints/src/misc.rs @@ -2,6 +2,7 @@ use crate::reexport::*; use rustc::hir::*; use rustc::hir::intravisit::FnKind; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use syntax::codemap::{ExpnFormat, Span}; use crate::utils::{get_item_name, get_parent_expr, implements_trait, in_constant, in_macro, is_integer_literal, diff --git a/clippy_lints/src/misc_early.rs b/clippy_lints/src/misc_early.rs index e527a05c8518..a5ee070d9009 100644 --- a/clippy_lints/src/misc_early.rs +++ b/clippy_lints/src/misc_early.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use std::collections::HashMap; use std::char; use syntax::ast::*; diff --git a/clippy_lints/src/missing_doc.rs b/clippy_lints/src/missing_doc.rs index eb4dfe8ba1c2..750fdfde5062 100644 --- a/clippy_lints/src/missing_doc.rs +++ b/clippy_lints/src/missing_doc.rs @@ -20,6 +20,7 @@ use rustc::hir; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use syntax::ast; use syntax::attr; diff --git a/clippy_lints/src/missing_inline.rs b/clippy_lints/src/missing_inline.rs index 0ca1c53d696e..a07c8329a73f 100644 --- a/clippy_lints/src/missing_inline.rs +++ b/clippy_lints/src/missing_inline.rs @@ -11,6 +11,7 @@ use rustc::hir; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast; use syntax::codemap::Span; diff --git a/clippy_lints/src/multiple_crate_versions.rs b/clippy_lints/src/multiple_crate_versions.rs index d347270236dd..b484488b1063 100644 --- a/clippy_lints/src/multiple_crate_versions.rs +++ b/clippy_lints/src/multiple_crate_versions.rs @@ -1,6 +1,7 @@ //! lint on multiple versions of a crate being used use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::*; use cargo_metadata; diff --git a/clippy_lints/src/mut_mut.rs b/clippy_lints/src/mut_mut.rs index ef08e60c4efe..f3918f542df3 100644 --- a/clippy_lints/src/mut_mut.rs +++ b/clippy_lints/src/mut_mut.rs @@ -1,6 +1,7 @@ use rustc::hir; use rustc::hir::intravisit; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use crate::utils::{higher, in_external_macro, span_lint}; diff --git a/clippy_lints/src/mut_reference.rs b/clippy_lints/src/mut_reference.rs index b4d6652a65a4..de4c54444400 100644 --- a/clippy_lints/src/mut_reference.rs +++ b/clippy_lints/src/mut_reference.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, Ty}; use rustc::ty::subst::Subst; use rustc::hir::*; diff --git a/clippy_lints/src/mutex_atomic.rs b/clippy_lints/src/mutex_atomic.rs index e5679bb7ba50..2448cd84d7c7 100644 --- a/clippy_lints/src/mutex_atomic.rs +++ b/clippy_lints/src/mutex_atomic.rs @@ -3,6 +3,7 @@ //! This lint is **warn** by default use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, Ty}; use rustc::hir::Expr; use syntax::ast; diff --git a/clippy_lints/src/needless_bool.rs b/clippy_lints/src/needless_bool.rs index 2fd5ff9a2464..559aa74f9a22 100644 --- a/clippy_lints/src/needless_bool.rs +++ b/clippy_lints/src/needless_bool.rs @@ -3,6 +3,7 @@ //! This lint is **warn** by default use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use syntax::ast::LitKind; use syntax::codemap::Spanned; diff --git a/clippy_lints/src/needless_borrow.rs b/clippy_lints/src/needless_borrow.rs index 90e41bc6f68a..728ca969ac58 100644 --- a/clippy_lints/src/needless_borrow.rs +++ b/clippy_lints/src/needless_borrow.rs @@ -3,6 +3,7 @@ //! This lint is **warn** by default use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::{BindingAnnotation, Expr, ExprKind, MutImmutable, Pat, PatKind}; use rustc::ty; use rustc::ty::adjustment::{Adjust, Adjustment}; diff --git a/clippy_lints/src/needless_borrowed_ref.rs b/clippy_lints/src/needless_borrowed_ref.rs index 91cc01891a97..ebefcfcca167 100644 --- a/clippy_lints/src/needless_borrowed_ref.rs +++ b/clippy_lints/src/needless_borrowed_ref.rs @@ -3,6 +3,7 @@ //! This lint is **warn** by default use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::{BindingAnnotation, MutImmutable, Pat, PatKind}; use crate::utils::{in_macro, snippet, span_lint_and_then}; diff --git a/clippy_lints/src/needless_continue.rs b/clippy_lints/src/needless_continue.rs index 3258bcd069a7..0b955bbfdff6 100644 --- a/clippy_lints/src/needless_continue.rs +++ b/clippy_lints/src/needless_continue.rs @@ -28,6 +28,7 @@ //! //! This lint is **warn** by default. use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast; use syntax::codemap::{original_sp, DUMMY_SP}; use std::borrow::Cow; diff --git a/clippy_lints/src/needless_pass_by_value.rs b/clippy_lints/src/needless_pass_by_value.rs index fa0586c1548a..6b961eedeb70 100644 --- a/clippy_lints/src/needless_pass_by_value.rs +++ b/clippy_lints/src/needless_pass_by_value.rs @@ -2,6 +2,7 @@ use rustc::hir::*; use rustc::hir::map::*; use rustc::hir::intravisit::FnKind; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, RegionKind, TypeFoldable}; use rustc::traits; use rustc::middle::expr_use_visitor as euv; diff --git a/clippy_lints/src/needless_update.rs b/clippy_lints/src/needless_update.rs index 9c670c1a5b3e..52c4c6e52371 100644 --- a/clippy_lints/src/needless_update.rs +++ b/clippy_lints/src/needless_update.rs @@ -1,4 +1,5 @@ use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use rustc::ty; use rustc::hir::{Expr, ExprKind}; use crate::utils::span_lint; diff --git a/clippy_lints/src/neg_cmp_op_on_partial_ord.rs b/clippy_lints/src/neg_cmp_op_on_partial_ord.rs index e0374b80dd81..fd2266c86144 100644 --- a/clippy_lints/src/neg_cmp_op_on_partial_ord.rs +++ b/clippy_lints/src/neg_cmp_op_on_partial_ord.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use crate::utils::{self, paths, span_lint, in_external_macro}; diff --git a/clippy_lints/src/neg_multiply.rs b/clippy_lints/src/neg_multiply.rs index e30ac8695dc8..0a12217e8d0c 100644 --- a/clippy_lints/src/neg_multiply.rs +++ b/clippy_lints/src/neg_multiply.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::codemap::{Span, Spanned}; use crate::consts::{self, Constant}; diff --git a/clippy_lints/src/new_without_default.rs b/clippy_lints/src/new_without_default.rs index 6be340a99f4a..80c92042687e 100644 --- a/clippy_lints/src/new_without_default.rs +++ b/clippy_lints/src/new_without_default.rs @@ -1,6 +1,7 @@ use rustc::hir::def_id::DefId; use rustc::hir; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, Ty}; use syntax::codemap::Span; use crate::utils::paths; diff --git a/clippy_lints/src/no_effect.rs b/clippy_lints/src/no_effect.rs index 5180ff348778..dc83b29854c7 100644 --- a/clippy_lints/src/no_effect.rs +++ b/clippy_lints/src/no_effect.rs @@ -1,4 +1,5 @@ use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use rustc::hir::def::Def; use rustc::hir::{BinOpKind, BlockCheckMode, Expr, ExprKind, Stmt, StmtKind, UnsafeSource}; use crate::utils::{has_drop, in_macro, snippet_opt, span_lint, span_lint_and_sugg}; diff --git a/clippy_lints/src/non_copy_const.rs b/clippy_lints/src/non_copy_const.rs index 981451947bfe..f2c9210aae4e 100644 --- a/clippy_lints/src/non_copy_const.rs +++ b/clippy_lints/src/non_copy_const.rs @@ -3,6 +3,7 @@ //! This lint is **deny** by default. use rustc::lint::{LateContext, LateLintPass, Lint, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::hir::def::Def; use rustc::ty::{self, TypeFlags}; diff --git a/clippy_lints/src/non_expressive_names.rs b/clippy_lints/src/non_expressive_names.rs index b49e3f87ec99..8f21523f4044 100644 --- a/clippy_lints/src/non_expressive_names.rs +++ b/clippy_lints/src/non_expressive_names.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::codemap::Span; use syntax::symbol::LocalInternedString; use syntax::ast::*; diff --git a/clippy_lints/src/ok_if_let.rs b/clippy_lints/src/ok_if_let.rs index 0a1399075e06..6a21807b90b3 100644 --- a/clippy_lints/src/ok_if_let.rs +++ b/clippy_lints/src/ok_if_let.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::{match_type, method_chain_args, paths, snippet, span_help_and_lint}; diff --git a/clippy_lints/src/open_options.rs b/clippy_lints/src/open_options.rs index b4559969ac24..06b48b9eeac5 100644 --- a/clippy_lints/src/open_options.rs +++ b/clippy_lints/src/open_options.rs @@ -1,5 +1,6 @@ use rustc::hir::{Expr, ExprKind}; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::LitKind; use syntax::codemap::{Span, Spanned}; use crate::utils::{match_type, paths, span_lint, walk_ptrs_ty}; diff --git a/clippy_lints/src/overflow_check_conditional.rs b/clippy_lints/src/overflow_check_conditional.rs index 8783055b31ee..0ae400879da0 100644 --- a/clippy_lints/src/overflow_check_conditional.rs +++ b/clippy_lints/src/overflow_check_conditional.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::{span_lint, SpanlessEq}; diff --git a/clippy_lints/src/panic_unimplemented.rs b/clippy_lints/src/panic_unimplemented.rs index 24cf6544f6a0..2edcef5bcda4 100644 --- a/clippy_lints/src/panic_unimplemented.rs +++ b/clippy_lints/src/panic_unimplemented.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::LitKind; use syntax::ptr::P; use syntax::ext::quote::rt::Span; diff --git a/clippy_lints/src/partialeq_ne_impl.rs b/clippy_lints/src/partialeq_ne_impl.rs index 2d283b96f867..e001bbebd3c2 100644 --- a/clippy_lints/src/partialeq_ne_impl.rs +++ b/clippy_lints/src/partialeq_ne_impl.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::{is_automatically_derived, span_lint}; diff --git a/clippy_lints/src/precedence.rs b/clippy_lints/src/precedence.rs index 7f5dd2abc0e0..76ea9c5ade60 100644 --- a/clippy_lints/src/precedence.rs +++ b/clippy_lints/src/precedence.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::*; use syntax::codemap::Spanned; use crate::utils::{in_macro, snippet, span_lint_and_sugg}; diff --git a/clippy_lints/src/ptr.rs b/clippy_lints/src/ptr.rs index 22804764d8aa..5093819db5f5 100644 --- a/clippy_lints/src/ptr.rs +++ b/clippy_lints/src/ptr.rs @@ -5,6 +5,7 @@ use rustc::hir::*; use rustc::hir::map::NodeItem; use rustc::hir::QPath; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use syntax::ast::NodeId; use syntax::codemap::Span; diff --git a/clippy_lints/src/question_mark.rs b/clippy_lints/src/question_mark.rs index b8e7a2646c48..9ede9afebd73 100644 --- a/clippy_lints/src/question_mark.rs +++ b/clippy_lints/src/question_mark.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::hir::def::Def; use crate::utils::sugg::Sugg; diff --git a/clippy_lints/src/ranges.rs b/clippy_lints/src/ranges.rs index 2fb3bf5182cd..03bf7be4285f 100644 --- a/clippy_lints/src/ranges.rs +++ b/clippy_lints/src/ranges.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use syntax::ast::RangeLimits; use syntax::codemap::Spanned; diff --git a/clippy_lints/src/redundant_field_names.rs b/clippy_lints/src/redundant_field_names.rs index d179bffd59ad..4f28d36e2a8f 100644 --- a/clippy_lints/src/redundant_field_names.rs +++ b/clippy_lints/src/redundant_field_names.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::{in_macro, is_range_expression, match_var, span_lint_and_sugg}; diff --git a/clippy_lints/src/reference.rs b/clippy_lints/src/reference.rs index d8179816236b..6baa61745634 100644 --- a/clippy_lints/src/reference.rs +++ b/clippy_lints/src/reference.rs @@ -1,5 +1,6 @@ use syntax::ast::{Expr, ExprKind, UnOp}; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use crate::utils::{snippet, span_lint_and_sugg}; /// **What it does:** Checks for usage of `*&` and `*&mut` in expressions. diff --git a/clippy_lints/src/regex.rs b/clippy_lints/src/regex.rs index fbead26a03b0..114a14bdf967 100644 --- a/clippy_lints/src/regex.rs +++ b/clippy_lints/src/regex.rs @@ -1,6 +1,7 @@ use regex_syntax; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use std::collections::HashSet; use syntax::ast::{LitKind, NodeId, StrStyle}; use syntax::codemap::{BytePos, Span}; diff --git a/clippy_lints/src/replace_consts.rs b/clippy_lints/src/replace_consts.rs index f149e3248772..5f5957b02099 100644 --- a/clippy_lints/src/replace_consts.rs +++ b/clippy_lints/src/replace_consts.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir; use rustc::hir::def::Def; use crate::utils::{match_def_path, span_lint_and_sugg}; diff --git a/clippy_lints/src/returns.rs b/clippy_lints/src/returns.rs index 03a5d58a3eec..29d50d87fb8d 100644 --- a/clippy_lints/src/returns.rs +++ b/clippy_lints/src/returns.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast; use syntax::codemap::Span; use syntax::visit::FnKind; diff --git a/clippy_lints/src/serde_api.rs b/clippy_lints/src/serde_api.rs index 55c51307e04d..ce326ea72ca8 100644 --- a/clippy_lints/src/serde_api.rs +++ b/clippy_lints/src/serde_api.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::{get_trait_def_id, paths, span_lint}; diff --git a/clippy_lints/src/shadow.rs b/clippy_lints/src/shadow.rs index cc08e1ee816f..563530c1ae7f 100644 --- a/clippy_lints/src/shadow.rs +++ b/clippy_lints/src/shadow.rs @@ -1,5 +1,6 @@ use crate::reexport::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::hir::intravisit::FnKind; use rustc::ty; diff --git a/clippy_lints/src/strings.rs b/clippy_lints/src/strings.rs index 40f5c66ce158..fa8102308d8f 100644 --- a/clippy_lints/src/strings.rs +++ b/clippy_lints/src/strings.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::codemap::Spanned; use crate::utils::SpanlessEq; use crate::utils::{get_parent_expr, is_allowed, match_type, paths, span_lint, span_lint_and_sugg, walk_ptrs_ty}; diff --git a/clippy_lints/src/suspicious_trait_impl.rs b/clippy_lints/src/suspicious_trait_impl.rs index 10db53cc782d..704ad04325da 100644 --- a/clippy_lints/src/suspicious_trait_impl.rs +++ b/clippy_lints/src/suspicious_trait_impl.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir; use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor}; use syntax::ast; diff --git a/clippy_lints/src/swap.rs b/clippy_lints/src/swap.rs index dfcc9c39348f..d8bf6e567f6c 100644 --- a/clippy_lints/src/swap.rs +++ b/clippy_lints/src/swap.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty; use crate::utils::{differing_macro_contexts, match_type, paths, snippet, span_lint_and_then, walk_ptrs_ty, SpanlessEq}; use crate::utils::sugg::Sugg; diff --git a/clippy_lints/src/temporary_assignment.rs b/clippy_lints/src/temporary_assignment.rs index 008ab56bda84..56e705ad0a72 100644 --- a/clippy_lints/src/temporary_assignment.rs +++ b/clippy_lints/src/temporary_assignment.rs @@ -1,4 +1,5 @@ use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use rustc::hir::{Expr, ExprKind}; use crate::utils::is_adjusted; use crate::utils::span_lint; diff --git a/clippy_lints/src/transmute.rs b/clippy_lints/src/transmute.rs index 9914ab0e8db3..7abf5fdcc923 100644 --- a/clippy_lints/src/transmute.rs +++ b/clippy_lints/src/transmute.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, Ty}; use rustc::hir::*; use std::borrow::Cow; diff --git a/clippy_lints/src/trivially_copy_pass_by_ref.rs b/clippy_lints/src/trivially_copy_pass_by_ref.rs index 18c85cd05ab4..57d9ddf39552 100644 --- a/clippy_lints/src/trivially_copy_pass_by_ref.rs +++ b/clippy_lints/src/trivially_copy_pass_by_ref.rs @@ -4,6 +4,7 @@ use rustc::hir::*; use rustc::hir::map::*; use rustc::hir::intravisit::FnKind; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::TypeVariants; use rustc::session::config::Config as SessionConfig; use rustc_target::spec::abi::Abi; diff --git a/clippy_lints/src/types.rs b/clippy_lints/src/types.rs index ae4f579a6f22..df14eb159570 100644 --- a/clippy_lints/src/types.rs +++ b/clippy_lints/src/types.rs @@ -3,6 +3,7 @@ use rustc::hir; use rustc::hir::*; use rustc::hir::intravisit::{walk_body, walk_expr, walk_ty, FnKind, NestedVisitorMap, Visitor}; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, Ty, TyCtxt, TypeckTables}; use rustc::ty::layout::LayoutOf; use rustc_typeck::hir_ty_to_ty; diff --git a/clippy_lints/src/unicode.rs b/clippy_lints/src/unicode.rs index ddd9db9eda3a..c4a795bfacb3 100644 --- a/clippy_lints/src/unicode.rs +++ b/clippy_lints/src/unicode.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use syntax::ast::{LitKind, NodeId}; use syntax::codemap::Span; diff --git a/clippy_lints/src/unsafe_removed_from_name.rs b/clippy_lints/src/unsafe_removed_from_name.rs index a1f31770ec0a..a6cab8923242 100644 --- a/clippy_lints/src/unsafe_removed_from_name.rs +++ b/clippy_lints/src/unsafe_removed_from_name.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use syntax::ast::*; use syntax::codemap::Span; use syntax::symbol::LocalInternedString; diff --git a/clippy_lints/src/unused_io_amount.rs b/clippy_lints/src/unused_io_amount.rs index 649a10333710..e4dac731cf2c 100644 --- a/clippy_lints/src/unused_io_amount.rs +++ b/clippy_lints/src/unused_io_amount.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir; use crate::utils::{is_try, match_qpath, match_trait_method, paths, span_lint}; diff --git a/clippy_lints/src/unused_label.rs b/clippy_lints/src/unused_label.rs index 0ae956b9443e..1681a303fd37 100644 --- a/clippy_lints/src/unused_label.rs +++ b/clippy_lints/src/unused_label.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir; use rustc::hir::intravisit::{walk_expr, walk_fn, FnKind, NestedVisitorMap, Visitor}; use std::collections::HashMap; diff --git a/clippy_lints/src/unwrap.rs b/clippy_lints/src/unwrap.rs index fcc3c2f68c1c..4f7e9e9c0a15 100644 --- a/clippy_lints/src/unwrap.rs +++ b/clippy_lints/src/unwrap.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use crate::utils::{in_macro, match_type, paths, span_lint_and_then, usage::is_potentially_mutated}; use rustc::hir::intravisit::*; diff --git a/clippy_lints/src/use_self.rs b/clippy_lints/src/use_self.rs index 230d5fdca2c6..3b6773792986 100644 --- a/clippy_lints/src/use_self.rs +++ b/clippy_lints/src/use_self.rs @@ -1,4 +1,5 @@ use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::hir::intravisit::{walk_path, NestedVisitorMap, Visitor}; use crate::utils::{in_macro, span_lint_and_then}; diff --git a/clippy_lints/src/utils/author.rs b/clippy_lints/src/utils/author.rs index 9a848c8a805d..4310325475a3 100644 --- a/clippy_lints/src/utils/author.rs +++ b/clippy_lints/src/utils/author.rs @@ -4,6 +4,7 @@ #![allow(print_stdout, use_debug)] use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir; use rustc::hir::{Expr, ExprKind, QPath, TyKind, Pat, PatKind, BindingAnnotation, StmtKind, DeclKind, Stmt}; use rustc::hir::intravisit::{NestedVisitorMap, Visitor}; diff --git a/clippy_lints/src/utils/inspector.rs b/clippy_lints/src/utils/inspector.rs index b2b99da3c59a..969e3414f178 100644 --- a/clippy_lints/src/utils/inspector.rs +++ b/clippy_lints/src/utils/inspector.rs @@ -3,6 +3,7 @@ //! checks for attributes use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir; use rustc::hir::print; use syntax::ast::Attribute; diff --git a/clippy_lints/src/utils/internal_lints.rs b/clippy_lints/src/utils/internal_lints.rs index a348df83a9d1..3d43d595defe 100644 --- a/clippy_lints/src/utils/internal_lints.rs +++ b/clippy_lints/src/utils/internal_lints.rs @@ -1,4 +1,5 @@ use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use rustc::hir; use rustc::hir::intravisit::{walk_expr, NestedVisitorMap, Visitor}; diff --git a/clippy_lints/src/vec.rs b/clippy_lints/src/vec.rs index 39ab77c3afa1..68caa5b44942 100644 --- a/clippy_lints/src/vec.rs +++ b/clippy_lints/src/vec.rs @@ -1,5 +1,6 @@ use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::ty::{self, Ty}; use syntax::codemap::Span; use crate::utils::{higher, is_copy, snippet, span_lint_and_sugg}; diff --git a/clippy_lints/src/write.rs b/clippy_lints/src/write.rs index 556d128bca79..5112ad86ff0b 100644 --- a/clippy_lints/src/write.rs +++ b/clippy_lints/src/write.rs @@ -1,6 +1,7 @@ use rustc::hir::map::Node::{NodeImplItem, NodeItem}; use rustc::hir::*; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use std::ops::Deref; use syntax::ast::LitKind; use syntax::ptr; diff --git a/clippy_lints/src/zero_div_zero.rs b/clippy_lints/src/zero_div_zero.rs index 5232d5714f13..0b1b3a413055 100644 --- a/clippy_lints/src/zero_div_zero.rs +++ b/clippy_lints/src/zero_div_zero.rs @@ -1,5 +1,6 @@ use crate::consts::{constant_simple, Constant}; use rustc::lint::*; +use rustc::{declare_lint, lint_array}; use rustc::hir::*; use crate::utils::span_help_and_lint;