From 5db01aae99a82675565c333ece511daa31d545cb Mon Sep 17 00:00:00 2001 From: bjorn3 Date: Mon, 3 May 2021 18:38:52 +0200 Subject: [PATCH] Take build dependencies into account during license checks The comment says that build dependencies shouldn't matter unless they do some kind of codegen. It is safer to always check it though. --- src/tools/tidy/src/deps.rs | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/tools/tidy/src/deps.rs b/src/tools/tidy/src/deps.rs index 86231946bb72..91008fc9fb7f 100644 --- a/src/tools/tidy/src/deps.rs +++ b/src/tools/tidy/src/deps.rs @@ -460,16 +460,7 @@ fn normal_deps_of_r<'a>( .iter() .find(|n| &n.id == pkg_id) .unwrap_or_else(|| panic!("could not find `{}` in resolve", pkg_id)); - // Don't care about dev-dependencies. - // Build dependencies *shouldn't* matter unless they do some kind of - // codegen. For now we'll assume they don't. - let deps = node.deps.iter().filter(|node_dep| { - node_dep - .dep_kinds - .iter() - .any(|kind_info| kind_info.kind == cargo_metadata::DependencyKind::Normal) - }); - for dep in deps { + for dep in &node.deps { normal_deps_of_r(resolve, &dep.pkg, result); } }