More PR feedback

This commit is contained in:
Scott McMurray 2025-01-31 22:31:43 -08:00
parent 61150a80f5
commit 5e6ae8bb5c
2 changed files with 5 additions and 7 deletions

View file

@ -3247,7 +3247,7 @@ pub const fn three_way_compare<T: Copy>(_lhs: T, _rhss: T) -> crate::cmp::Orderi
/// Combine two values which have no bits in common.
///
/// This allows the backend to implement it as `a + b` *or* `a | b`,
/// depending which us easier to implement on a specific target.
/// depending which is easier to implement on a specific target.
///
/// # Safety
///

View file

@ -1187,13 +1187,11 @@ macro_rules! uint_impl {
self % rhs
}
/// Same value as
#[doc = concat!("`<", stringify!($SelfT), " as BitOr>::bitor(self, other)`")]
/// but UB if any bit position is set in both inputs.
/// Same value as `self | other`, but UB if any bit position is set in both inputs.
///
/// This is a situational μoptimization for places where you'd rather use
/// addition on some platforms and bitwise or on other platforms, based on
/// exactly which instructions combine better with whatever else you're
/// This is a situational micro-optimization for places where you'd rather
/// use addition on some platforms and bitwise or on other platforms, based
/// on exactly which instructions combine better with whatever else you're
/// doing. Note that there's no reason to bother using this for places
/// where it's clear from the operations involved that they can't overlap.
/// For example, if you're combining `u16`s into a `u32` with