From 5e7ff6b7058a5d6da2245145441f2ff2f9e69068 Mon Sep 17 00:00:00 2001 From: Matthew Jasper Date: Sun, 8 Sep 2019 11:40:04 +0100 Subject: [PATCH] Update non_expressive_names for or patterns --- clippy_lints/src/non_expressive_names.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/clippy_lints/src/non_expressive_names.rs b/clippy_lints/src/non_expressive_names.rs index a9977a93b323..88bf52b1e8db 100644 --- a/clippy_lints/src/non_expressive_names.rs +++ b/clippy_lints/src/non_expressive_names.rs @@ -136,6 +136,9 @@ impl<'a, 'tcx, 'b> Visitor<'tcx> for SimilarNamesNameVisitor<'a, 'tcx, 'b> { } } }, + // just go through the first pattern, as either all patterns + // bind the same bindings or rustc would have errored much earlier + PatKind::Or(ref pats) => self.visit_pat(&pats[0]), _ => walk_pat(self, pat), } } @@ -325,8 +328,6 @@ impl<'a, 'tcx> Visitor<'tcx> for SimilarNamesLocalVisitor<'a, 'tcx> { self.single_char_names.push(vec![]); self.apply(|this| { - // just go through the first pattern, as either all patterns - // bind the same bindings or rustc would have errored much earlier SimilarNamesNameVisitor(this).visit_pat(&arm.pat); this.apply(|this| walk_expr(this, &arm.body)); });