user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix bug: allow no- '_'-split binary format string, add test

Browse source
This commit is contained in:
cocodery 2024-01-06 21:41:25 +08:00
parent 79e70ccf6f
commit 60c647b262
4 changed files with 17 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
clippy_lints/src/non_octal_unix_permissions.rs
View file

@ -50,10 +50,15 @@ fn check_binary_unix_permissions(lit_kind: &LitKind, snip: &str) -> bool {
let group_sizes: Vec<usize> = num_lit.integer.split('_').map(str::len).collect();
// check whether is binary format unix permissions
if group_sizes.len() != 3 && group_sizes.len() != 4 {
return false;
if group_sizes.len() == 1 && (num_lit.integer.len() == 9 || num_lit.integer.len() == 12) {
// 0bxxxxxxxxx or 0bxxxxxxxxxxxx
true
} else if group_sizes.len() == 3 || group_sizes.len() == 4 {
// 0bxxx_xxx_xxx or 0bxxx_xxx_xxx_xxx
group_sizes.iter().all(|len| *len == 3)
} else {
false
}
group_sizes.iter().all(|len| *len == 3)
} else {
false
}