Extend invalid_atomic_ordering to detect misuse of compare_exchange{,_weak}
This commit is contained in:
Thom Chiovoloni
parent
8b54f1e2d9
commit
6211599cca
3 changed files with 423 additions and 2 deletions
84
tests/ui/atomic_ordering_exchange.rs
Normal file
84
tests/ui/atomic_ordering_exchange.rs
Normal file
|
|
@ -0,0 +1,84 @@
|
|||
#![warn(clippy::invalid_atomic_ordering)]
|
||||
|
||||
use std::sync::atomic::{AtomicUsize, Ordering};
|
||||
|
||||
fn main() {
|
||||
// `compare_exchange` (not weak) testing
|
||||
let x = AtomicUsize::new(0);
|
||||
|
||||
// Allowed ordering combos
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Relaxed, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Acquire, Ordering::Acquire);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Acquire, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Release, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::AcqRel, Ordering::Acquire);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::AcqRel, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::SeqCst, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::SeqCst, Ordering::Acquire);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::SeqCst, Ordering::SeqCst);
|
||||
|
||||
// AcqRel is always forbidden as a failure ordering
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Relaxed, Ordering::AcqRel);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Acquire, Ordering::AcqRel);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Release, Ordering::AcqRel);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::AcqRel, Ordering::AcqRel);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::SeqCst, Ordering::AcqRel);
|
||||
|
||||
// Release is always forbidden as a failure ordering
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Relaxed, Ordering::Release);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Acquire, Ordering::Release);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Release, Ordering::Release);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::AcqRel, Ordering::Release);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::SeqCst, Ordering::Release);
|
||||
|
||||
// Release success order forbids failure order of Acquire or SeqCst
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Release, Ordering::Acquire);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Release, Ordering::SeqCst);
|
||||
|
||||
// Relaxed success order also forbids failure order of Acquire or SeqCst
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Relaxed, Ordering::SeqCst);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Relaxed, Ordering::Acquire);
|
||||
|
||||
// Acquire/AcqRel forbids failure order of SeqCst
|
||||
let _ = x.compare_exchange(0, 0, Ordering::Acquire, Ordering::SeqCst);
|
||||
let _ = x.compare_exchange(0, 0, Ordering::AcqRel, Ordering::SeqCst);
|
||||
|
||||
// compare_exchange_weak tests
|
||||
|
||||
// Allowed ordering combos
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Relaxed, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Acquire, Ordering::Acquire);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Acquire, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Release, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::AcqRel, Ordering::Acquire);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::AcqRel, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::SeqCst, Ordering::Relaxed);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::SeqCst, Ordering::Acquire);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::SeqCst, Ordering::SeqCst);
|
||||
|
||||
// AcqRel is always forbidden as a failure ordering
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Relaxed, Ordering::AcqRel);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Acquire, Ordering::AcqRel);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Release, Ordering::AcqRel);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::AcqRel, Ordering::AcqRel);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::SeqCst, Ordering::AcqRel);
|
||||
|
||||
// Release is always forbidden as a failure ordering
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Relaxed, Ordering::Release);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Acquire, Ordering::Release);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Release, Ordering::Release);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::AcqRel, Ordering::Release);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::SeqCst, Ordering::Release);
|
||||
|
||||
// Release success order forbids failure order of Acquire or SeqCst
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Release, Ordering::Acquire);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Release, Ordering::SeqCst);
|
||||
|
||||
// Relaxed success order also forbids failure order of Acquire or SeqCst
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Relaxed, Ordering::SeqCst);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Relaxed, Ordering::Acquire);
|
||||
|
||||
// Acquire/AcqRel forbids failure order of SeqCst
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::Acquire, Ordering::SeqCst);
|
||||
let _ = x.compare_exchange_weak(0, 0, Ordering::AcqRel, Ordering::SeqCst);
|
||||
}
|
||||
259
tests/ui/atomic_ordering_exchange.stderr
Normal file
259
tests/ui/atomic_ordering_exchange.stderr
Normal file
|
|
@ -0,0 +1,259 @@
|
|||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:21:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Relaxed, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: `-D clippy::invalid-atomic-ordering` implied by `-D warnings`
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:22:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Acquire, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:23:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Release, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:24:56
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::AcqRel, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:25:56
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::SeqCst, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire`, `SeqCst` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:28:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Relaxed, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:29:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Acquire, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:30:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Release, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:31:56
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::AcqRel, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:32:56
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::SeqCst, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire`, `SeqCst` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not stronger than the success ordering of `Release`
|
||||
--> $DIR/atomic_ordering_exchange.rs:35:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Release, Ordering::Acquire);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not stronger than the success ordering of `Release`
|
||||
--> $DIR/atomic_ordering_exchange.rs:36:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Release, Ordering::SeqCst);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not stronger than the success ordering of `Relaxed`
|
||||
--> $DIR/atomic_ordering_exchange.rs:39:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Relaxed, Ordering::SeqCst);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not stronger than the success ordering of `Relaxed`
|
||||
--> $DIR/atomic_ordering_exchange.rs:40:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Relaxed, Ordering::Acquire);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not stronger than the success ordering of `Acquire`
|
||||
--> $DIR/atomic_ordering_exchange.rs:43:57
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::Acquire, Ordering::SeqCst);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange's failure ordering may not stronger than the success ordering of `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:44:56
|
||||
|
|
||||
LL | let _ = x.compare_exchange(0, 0, Ordering::AcqRel, Ordering::SeqCst);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:60:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Relaxed, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:61:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Acquire, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:62:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Release, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:63:61
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::AcqRel, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:64:61
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::SeqCst, Ordering::AcqRel);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire`, `SeqCst` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:67:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Relaxed, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:68:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Acquire, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:69:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Release, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:70:61
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::AcqRel, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not be `Release` or `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:71:61
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::SeqCst, Ordering::Release);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire`, `SeqCst` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not stronger than the success ordering of `Release`
|
||||
--> $DIR/atomic_ordering_exchange.rs:74:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Release, Ordering::Acquire);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not stronger than the success ordering of `Release`
|
||||
--> $DIR/atomic_ordering_exchange.rs:75:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Release, Ordering::SeqCst);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not stronger than the success ordering of `Relaxed`
|
||||
--> $DIR/atomic_ordering_exchange.rs:78:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Relaxed, Ordering::SeqCst);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not stronger than the success ordering of `Relaxed`
|
||||
--> $DIR/atomic_ordering_exchange.rs:79:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Relaxed, Ordering::Acquire);
|
||||
| ^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering mode `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not stronger than the success ordering of `Acquire`
|
||||
--> $DIR/atomic_ordering_exchange.rs:82:62
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::Acquire, Ordering::SeqCst);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: compare_exchange_weak's failure ordering may not stronger than the success ordering of `AcqRel`
|
||||
--> $DIR/atomic_ordering_exchange.rs:83:61
|
||||
|
|
||||
LL | let _ = x.compare_exchange_weak(0, 0, Ordering::AcqRel, Ordering::SeqCst);
|
||||
| ^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= help: consider using ordering modes `Acquire` or `Relaxed` instead
|
||||
|
||||
error: aborting due to 32 previous errors
|
||||
|
||||
Loading…
Add table
Add a link
Reference in a new issue