user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rollup merge of #152753 - cyrgani:remove-hack, r=petrochenkov

Browse source 
remove the explicit error for old `rental` versions

This was converted to a hard error 20 months ago (in rust-lang/rust#125596). This seems like enough time for anyone still using it to notice, so remove the note entirely now.
In comparison, the explicit note for the more impactful `time` breakage was already removed after 6 months (rust-lang/rust#129343).

Closes rust-lang/rust#73933.
Closes rust-lang/rust#83125.

r? @petrochenkov
This commit is contained in:
Stuart Cook 2026-02-18 17:29:43 +11:00 • committed by GitHub
commit 64087bc8ec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 6 additions and 226 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/ui/proc-macro/pretty-print-hack-hide.rs
View file

@ -1,12 +0,0 @@
//@ proc-macro: test-macros.rs
//@ compile-flags: -Z span-debug
//@ check-pass
#![no_std] // Don't load unnecessary hygiene information from std
extern crate std;
#[macro_use] extern crate test_macros;
include!("pretty-print-hack/rental-0.5.6/src/lib.rs");
fn main() {}

21
tests/ui/proc-macro/pretty-print-hack-hide.stdout
View file

@ -1,21 +0,0 @@
PRINT-DERIVE INPUT (DISPLAY): enum ProceduralMasqueradeDummyType { Input }
PRINT-DERIVE INPUT (DEBUG): TokenStream [
Ident {
ident: "enum",
span: $DIR/pretty-print-hack/rental-0.5.6/src/lib.rs:4:1: 4:5 (#0),
},
Ident {
ident: "ProceduralMasqueradeDummyType",
span: $DIR/pretty-print-hack/rental-0.5.6/src/lib.rs:4:6: 4:35 (#0),
},
Group {
delimiter: Brace,
stream: TokenStream [
Ident {
ident: "Input",
span: $DIR/pretty-print-hack/rental-0.5.6/src/lib.rs:13:5: 13:10 (#0),
},
],
span: $DIR/pretty-print-hack/rental-0.5.6/src/lib.rs:4:36: 14:2 (#0),
},
]

6
tests/ui/proc-macro/pretty-print-hack-show.local.stderr
View file

@ -1,6 +0,0 @@
error: using an old version of `rental`
|
= note: older versions of the `rental` crate no longer compile; please update to `rental` v0.5.6, or switch to one of the `rental` alternatives
error: aborting due to 1 previous error

6
tests/ui/proc-macro/pretty-print-hack-show.remapped.stderr
View file

@ -1,6 +0,0 @@
error: using an old version of `rental`
|
= note: older versions of the `rental` crate no longer compile; please update to `rental` v0.5.6, or switch to one of the `rental` alternatives
error: aborting due to 1 previous error

21
tests/ui/proc-macro/pretty-print-hack-show.rs
View file

@ -1,21 +0,0 @@
//@ proc-macro: test-macros.rs
//@ compile-flags: -Z span-debug
//@ revisions: local remapped
//@ [remapped] remap-src-base
#![no_std] // Don't load unnecessary hygiene information from std
extern crate std;
#[macro_use] extern crate test_macros;
mod first {
include!("pretty-print-hack/allsorts-rental-0.5.6/src/lib.rs");
}
mod second {
include!("pretty-print-hack/rental-0.5.5/src/lib.rs");
}
fn main() {}
//~? ERROR using an old version of `rental`

14
tests/ui/proc-macro/pretty-print-hack/allsorts-rental-0.5.6/src/lib.rs
View file

@ -1,14 +0,0 @@
//@ ignore-auxiliary (used by `../../../pretty-print-hack-show.rs`)
#[derive(Print)]
enum ProceduralMasqueradeDummyType {
//~^ ERROR using
//~| WARN this was previously
//~| ERROR using
//~| WARN this was previously
//~| ERROR using
//~| WARN this was previously
//~| ERROR using
//~| WARN this was previously
Input
}

14
tests/ui/proc-macro/pretty-print-hack/rental-0.5.5/src/lib.rs
View file

@ -1,14 +0,0 @@
//@ ignore-auxiliary (used by `../../../pretty-print-hack-show.rs`)
#[derive(Print)]
enum ProceduralMasqueradeDummyType {
//~^ ERROR using
//~| WARN this was previously
//~| ERROR using
//~| WARN this was previously
//~| ERROR using
//~| WARN this was previously
//~| ERROR using
//~| WARN this was previously
Input
}

14
tests/ui/proc-macro/pretty-print-hack/rental-0.5.6/src/lib.rs
View file

@ -1,14 +0,0 @@
//@ ignore-auxiliary (used by `../../../pretty-print-hack/hide.rs`)
#[derive(Print)]
enum ProceduralMasqueradeDummyType {
//~^ ERROR using
//~| WARN this was previously
//~| ERROR using
//~| WARN this was previously
//~| ERROR using
//~| WARN this was previously
//~| ERROR using
//~| WARN this was previously
Input
}